Update Android push docs, and app setup for 1.17.0 #522

Jawnnypoo · 2018-05-02T06:01:15Z

For 1.17.0, the way you setup push changes for using FCM instead of GCM.

This also removes references to setting up the app in the Android Manifest in favor of setting it up in the Application class, using the builder.

Jawnnypoo · 2018-05-02T06:01:40Z

@rogerhu Do you mind taking a look?

rogerhu · 2018-05-02T06:22:35Z

_includes/parse-server/push-notifications-android.md

-  android:value="id:YOUR_SENDER_ID" />;
+```groovy
+dependencies {
+    implementation 'com.parse:parse-android-fcm:latest.version.here'


Let's set to 1.17.0 so it's ready to go!

Is there something that would replace the 1.17.0 with the later version when we do a new release? Otherwise, I think it is probably pretty annoying to have to edit these files all the time when there is a new release. Maybe just making this always say latest.version.here would be easier to maintain?

We can use https://api.bintray.com/packages/parse/maven/com.parse:parse-android/images/download.svg for our badge version..

(Trying to figure that out took 10 mins!)

Do you mean we would include the badge below that line of text or something?

Yeah it's always hard to figure out where to find the latest version is..

rogerhu · 2018-05-02T07:11:17Z

_includes/parse-server/push-notifications-android.md

 ```
+Then, follow Google's docs for [setting up an Firebase app](https://firebase.google.com/docs/android/setup). Although the steps are different for setting up FCM with Parse, it is also a good idea to read over the [Firebase FCM Setup](https://firebase.google.com/docs/cloud-messaging/android/client).

-Change the `android:name` attribute of `<category>` element above to match your application's package name.


We also should mention the migration from GCM to FCM link (https://developers.google.com/cloud-messaging/android/android-migrate-fcm)

I think we could potentially mention it in the README for GCM, but not here, since hopefully most won't need to care about it.

rogerhu · 2018-05-02T07:33:30Z

_includes/parse-server/push-notifications-android.md

-#### Configure Broadcast Receiver and Permissions
+#### FCM Push Setup

-Add the following service and broadcast receiver definitions to `AndroidManifest.xml` immediately before the *closing* `</application>` tag:


I think we're also forgetting that we need to add the app to the Firebase console, download the google-services.json and applying the apply plugin: 'com.google.gms.google-services' statement too?

https://firebase.google.com/docs/android/setup

It is mentioned below, in the "Then, follow Google's docs for setting up an Firebase app" text

Yes I found it confusing what to do given there are some steps that aren't necessary.

See: https://github.com/rogerhu/Parse-SDK-Android/blob/3748a0872f9a1263145a9b299210089101b64707/README.md#migrating-to-firebase

rogerhu · 2018-05-02T07:41:18Z

_includes/android/getting-started.md

      .server("http://localhost:1337/parse/")
      .build()
    );
  }


Don't we have to do ParseFCM.register(this); in the Application instance if we want push?

(Or ParseGCM.register(this)) for an older version..)

Nope, it is not required for FCM. I think we will leave the GCM instructions out of here, only mentioning it at the bottom, so that people will move away from it.

I was playing with it last night but couldnt get stuff to fire unless I did the register command with FCM...you sure it works without it?

Never mind, I was putting a breakpoint on the wrong place. Works fine!

See my updates about how a JobService is scheduled to run when the app starts:

https://github.com/parse-community/Parse-SDK-Android/pull/817/files

rogerhu · 2018-05-02T07:54:16Z

_includes/android/push-notifications.md

-<meta-data android:name="com.parse.push.gcm_sender_id"
-           android:value="id:YOUR_SENDER_ID_1,YOUR_SENDER_ID_2,YOUR_SENDER_ID_3" />;
-```
+The Parse library provides push notifications using Firebase Cloud Messaging (FCM) if Google Play Services are available. Learn more about Google Play Services [here](https://firebase.google.com/docs/cloud-messaging/).


I think this section should include the fact that calling ParseFCM.register(this) automatically passes the Installation object to the Parse server as a GCM token type.

The user should never have to call this manually given our setup. Do you think we should still mention that it is happening?

Jawnnypoo · 2018-05-02T15:51:49Z

I think this should be good to go, other than the latest.version.here bit, if we want it to have a badge that show the latest version. I have a PR to test this out in the main repo parse-community/Parse-SDK-Android#815

rogerhu · 2018-05-02T16:31:42Z

We still need the bintray plugin to automate builds to jcenter...I.e. ./gradlew bintrayUpload

…

On Wed, May 2, 2018, 8:51 AM John Carlson ***@***.***> wrote: I think this should be good to go, other than the latest.version.here bit, if we want it to have a badge that show the latest version. I have a PR to test this out in the main repo parse-community/Parse-SDK-Android#815 <parse-community/Parse-SDK-Android#815> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#522 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAT8yRNdVhE33lawNVTYno_y6-k6cvieks5tudYXgaJpZM4Tu5b4> .

rogerhu · 2018-05-02T16:42:06Z

_includes/android/getting-started.md

    super.onCreate();
    Parse.initialize(new Parse.Configuration.Builder(this)
      .applicationId("YOUR_APP_ID")
+      .clientKey("YOUR_CLIENT_KEY")


Client key can be null, as it is by default

rogerhu · 2018-05-04T06:07:30Z

_includes/android/getting-started.md

 ```groovy
 dependencies {
-  implementation 'com.parse:parse-android:1.16.7'
+  implementation 'com.parse:parse-android:latest.version.here'


we should put a comment about adding the FCM package here as optional

implementation 'com.parse:parse-fcm-android:latest.version.here'

I think maybe we should have a note about push somewhere in the README, but there are plenty of people/apps that use Parse Android without using any form of push, so I think it might be confusing here.

rogerhu · 2018-05-04T17:30:20Z

I'm pushing and tagging 1.17.0 the Android SDK right now...can you help tweak up these changes so we can have it ready? Thanks!

rogerhu · 2018-05-06T17:26:01Z

pull requested #523 -- I had to revert 6a49413 because it breaks the npm build.

Can someone tell me why markup stops showing up on the local dev?

Update Android push docs, and app setup for 1.17.0

9ccd466

Remove unused doc

0b2a2d3

rogerhu reviewed May 2, 2018

View reviewed changes

rogerhu reviewed May 4, 2018

View reviewed changes

Jawnnypoo closed this Jun 1, 2018

Uh oh!

Update Android push docs, and app setup for 1.17.0 #522

Update Android push docs, and app setup for 1.17.0 #522

Uh oh!

Conversation

Jawnnypoo commented May 2, 2018

Uh oh!

Jawnnypoo commented May 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogerhu May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogerhu May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogerhu May 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jawnnypoo commented May 2, 2018

Uh oh!

rogerhu commented May 2, 2018 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogerhu commented May 4, 2018

Uh oh!

rogerhu commented May 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rogerhu May 2, 2018 •

edited

Loading

rogerhu May 2, 2018 •

edited

Loading

rogerhu May 4, 2018 •

edited

Loading