fix: Postgres query on non-existent column throws internal server error

[mtrezza]

Summary

Querying an internal field that has no corresponding column in the Postgres _User table (e.g. _tombstone) throws an internal server error instead of returning empty results like MongoDB.

This caused the flaky test rest query query internal field on Postgres. The flakiness depended on randomized test order: if the previous test triggered reconfigureServer(), the _User table was recreated (without a _tombstone column), and the query failed with PostgresMissingColumnError (42703). If the previous test used the lightweight performInitialization(), the _User table didn't exist, and the already-caught PostgresRelationDoesNotExistError (42P01) returned empty results.

The fix catches PostgresMissingColumnError in the Postgres adapter's find and count methods, aligning behavior with MongoDB and with the distinct method which already handles this case.

Issue

Fixes flaky test: https://github.com/parse-community/parse-server/actions/runs/23509218104/job/68425397105?pr=10307

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)
• Add security check
• Add new Parse Error codes to Parse JS SDK

Summary by CodeRabbit

• Bug Fixes
  • Improved query reliability to gracefully handle edge cases involving internal fields, returning appropriate empty results instead of throwing errors.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Added tests verifying that REST queries on the internal _tombstone field using useMasterKey: true return no results without errors. Modified PostgreSQL adapter to treat missing column errors (42703) as non-fatal in find() and count() operations, alongside existing missing table error handling.

Changes

Cohort / File(s)	Summary
PostgreSQL Error Handling src/Adapters/Storage/Postgres/PostgresStorageAdapter.js	Extended error handlers in find() and count() to suppress PostgresMissingColumnError (42703) in addition to existing PostgresRelationDoesNotExistError (42P01), returning empty results instead of rethrowing.
REST Query Tests spec/RestQuery.spec.js	Added two test cases verifying that querying the _tombstone field on Parse.User with useMasterKey: true returns no results and does not throw, covering both .find(...).length and .count() scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: handling Postgres queries on non-existent columns that previously threw internal server errors.
Description check	✅ Passed	The description covers the issue, approach, and marks relevant tasks complete, but sections lack detail and task checkboxes are mostly unchecked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Adapters/Storage/Postgres/PostgresStorageAdapter.js`:
- Around line 1995-1998: The current catch is swallowing all
PostgresMissingColumnError (42703) alongside PostgresRelationDoesNotExistError;
restrict that fallback so only the intended virtual-field cases (e.g., queries
referencing the synthetic _tombstone column) are treated as “missing column” and
converted to an empty result — otherwise rethrow the error. Update both places
that compare error.code to PostgresRelationDoesNotExistError and
PostgresMissingColumnError to inspect the error message or the originating
SQL/column name and only suppress the 42703 when it references the virtual field
(for example contains "_tombstone"); for any other 42703, throw the error so
real schema drift surfaces. Ensure the logic is applied at both occurrences
currently checking PostgresRelationDoesNotExistError and
PostgresMissingColumnError.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ea20beb-b269-4c1e-bd9a-6103bd5864b2

📥 Commits

Reviewing files that changed from the base of the PR and between 3f888b1 and 072a884.

📒 Files selected for processing (2)

• spec/RestQuery.spec.js
• src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (1bacddb) to head (072a884).
⚠️ Report is 41 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10308   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files         192      192           
  Lines       16502    16502           
  Branches      227      227           
=======================================
  Hits        15270    15270           
  Misses       1212     1212           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.7.0-alpha.5

[parseplatformorg]

🎉 This change has been released in version 9.7.0