Skip to content

fix: Batch login sub-request rate limit uses IP-based keying#10349

Merged
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:fix/batch-login-rate-limit-session-token-keying
Mar 29, 2026
Merged

fix: Batch login sub-request rate limit uses IP-based keying#10349
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:fix/batch-login-rate-limit-session-token-keying

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Mar 29, 2026

Issue

Batch login sub-request rate limit uses IP-based keying

Tasks

  • Add new tests
  • Add changes to code
  • Add changes to documentation (guides, repository pages, in-code comments)

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant bot commented Mar 29, 2026

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

@parseplatformorg
Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d42b03f5-2a5e-4a41-abf8-35b697c0c218

📥 Commits

Reviewing files that changed from the base of the PR and between 12d6fae and b532170.

📒 Files selected for processing (2)
  • spec/RateLimit.spec.js
  • src/batch.js

📝 Walkthrough

Walkthrough

Modified batch request rate-limiting to prevent bypass using session tokens. For /login endpoints in batch sub-requests, the sessionToken is removed from request info before rate-limit enforcement. Added test cases to verify batch login requests share IP-based rate-limit counters across both session and user zone configurations.

Changes

Cohort / File(s) Summary
Test Coverage
spec/RateLimit.spec.js
Added two new test cases verifying batch login sub-requests enforce IP-based rate limiting when configured with zone: Parse.Server.RateLimitZone.session and zone: Parse.Server.RateLimitZone.user, confirming second batch request fails with rate-limit error.
Batch Rate-Limiting Logic
src/batch.js
Modified rate-limit enforcement to clone req.info before passing to limit.handler; removes sessionToken from cloned info when routablePath is /login to ensure login sub-requests are rate-limited by IP rather than session token.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, but the repository template requires multiple sections including Issue, Approach, and Tasks. Add a complete pull request description following the template, including the issue/problem, approach/changes, and relevant task checkboxes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main fix: batch login sub-requests now use IP-based rate limit keying instead of session token-based keying.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (9080296) to head (b532170).
⚠️ Report is 9 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha   #10349   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files         192      192           
  Lines       16538    16541    +3     
  Branches      229      229           
=======================================
+ Hits        15303    15306    +3     
  Misses       1215     1215           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit 63c37c4 into parse-community:alpha Mar 29, 2026
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 29, 2026
# [9.7.0-alpha.15](9.7.0-alpha.14...9.7.0-alpha.15) (2026-03-29)

### Bug Fixes

* Batch login sub-request rate limit uses IP-based keying ([#10349](#10349)) ([63c37c4](63c37c4))
@parseplatformorg
Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.7.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 29, 2026
@mtrezza mtrezza deleted the fix/batch-login-rate-limit-session-token-keying branch March 29, 2026 15:12
parseplatformorg pushed a commit that referenced this pull request Mar 30, 2026
# [9.7.0](9.6.1...9.7.0) (2026-03-30)

### Bug Fixes

* Auth data exposed via verify password endpoint ([GHSA-wp76-gg32-8258](GHSA-wp76-gg32-8258)) ([#10323](#10323)) ([770be86](770be86))
* Batch login sub-request rate limit uses IP-based keying ([#10349](#10349)) ([63c37c4](63c37c4))
* Cloud Code trigger context vulnerable to prototype pollution ([#10352](#10352)) ([d5f5128](d5f5128))
* Cloud function validator bypass via prototype chain traversal ([GHSA-vpj2-qq7w-5qq6](GHSA-vpj2-qq7w-5qq6)) ([#10342](#10342)) ([dc59e27](dc59e27))
* Duplicate session destruction can cause unhandled promise rejection ([#10319](#10319)) ([92791c1](92791c1))
* GraphQL API endpoint ignores CORS origin restriction ([GHSA-q3p6-g7c4-829c](GHSA-q3p6-g7c4-829c)) ([#10334](#10334)) ([4dd0d3d](4dd0d3d))
* GraphQL complexity validator exponential fragment traversal DoS ([GHSA-mfj6-6p54-m98c](GHSA-mfj6-6p54-m98c)) ([#10344](#10344)) ([f759bda](f759bda))
* LiveQuery protected field leak via shared mutable state across concurrent subscribers ([GHSA-m983-v2ff-wq65](GHSA-m983-v2ff-wq65)) ([#10330](#10330)) ([776c71c](776c71c))
* LiveQuery protected-field guard bypass via array-like logical operator value ([GHSA-mmg8-87c5-jrc2](GHSA-mmg8-87c5-jrc2)) ([#10350](#10350)) ([f63fd1a](f63fd1a))
* Maintenance key blocked from querying protected fields ([#10290](#10290)) ([7c8b213](7c8b213))
* MFA single-use token bypass via concurrent authData login requests ([GHSA-w73w-g5xw-rwhf](GHSA-w73w-g5xw-rwhf)) ([#10326](#10326)) ([e7efbeb](e7efbeb))
* Missing error messages in Parse errors ([#10304](#10304)) ([f128048](f128048))
* Postgres query on non-existent column throws internal server error ([#10308](#10308)) ([c5c4325](c5c4325))
* Session field immutability bypass via falsy-value guard ([GHSA-f6j3-w9v3-cq22](GHSA-f6j3-w9v3-cq22)) ([#10347](#10347)) ([9080296](9080296))

### Features

* Add `protectedFieldsSaveResponseExempt` option to strip protected fields from save responses ([#10289](#10289)) ([4f7cb53](4f7cb53))
* Add `protectedFieldsTriggerExempt` option to exempt Cloud Code triggers from `protectedFields` ([#10288](#10288)) ([1610f98](1610f98))
* Add support for `partialFilterExpression` in MongoDB storage adapter ([#10346](#10346)) ([8dd7bf2](8dd7bf2))
* Extend storage adapter interface to optionally return `matchedCount` and `modifiedCount` from `DatabaseController.update` with `many: true` ([#10353](#10353)) ([aea7596](aea7596))
@parseplatformorg
Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.7.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants