feat: Add Parse.File option maxUploadSize to override the Parse Server option maxUploadSize per file upload#10093
Merged
mtrezza merged 3 commits intoparse-community:alphafrom Mar 4, 2026
Conversation
|
🚀 Thanks for opening this pull request! |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a master-key/IP-validated per-request maxUploadSize override via Changes
Sequence DiagramsequenceDiagram
participant Client
participant Router as FilesRouter
participant Early as _earlyHeadersMiddleware
participant Body as _bodyParsingMiddleware
participant Storage as FileStorage
Client->>Router: POST /files/:filename with X-Parse-File-Max-Upload-Size
Router->>Early: run early headers middleware
Early->>Early: validate appId & masterKey (and masterKeyIps)
alt valid override & credentials
Early->>Router: set req._maxUploadSizeOverride
Router->>Body: parse body (streaming or raw)
Body->>Body: compute effective max bytes (override or default)
Body->>Storage: stream or buffer data, enforcing limit
alt within limit
Storage-->>Client: 201 Created / success
else exceeds limit
Body-->>Client: FILE_SAVE_ERROR (exceeds)
end
else invalid credentials or header
Early-->>Client: 403 Forbidden or FILE_SAVE_ERROR (invalid override)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.41.0)spec/ParseFile.spec.jsThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/Routers/FilesRouter.js (2)
238-246: Optional: add a README note for the new override option.The inline code docs are good; a short README mention for
Parse.FilemaxUploadSizewould improve discoverability for users.Based on learnings: For new Parse Server features, checking README documentation is recommended, while new option documentation is optional rather than required.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Routers/FilesRouter.js` around lines 238 - 246, Add a short README entry documenting the new per-request upload size override (header `X-Parse-File-Max-Upload-Size`) and how to use it (requires master key, same format as server option like "50mb"/"1gb", and maps to `req._maxUploadSizeOverride` used by `_bodyParsingMiddleware`), referencing FilesRouter middleware behavior in `FilesRouter.js` so users can discover the feature and its security requirement.
247-273: Prefer shared auth validation to avoid drift.This block re-implements master-key/IP validation inline. Extracting/reusing a shared auth validator would reduce behavioral drift from
Middlewares.handleParseHeadersover time (especially around logging and future auth-path changes).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Routers/FilesRouter.js` around lines 247 - 273, This inline master-key/IP validation in _earlyHeadersMiddleware duplicates logic from Middlewares.handleParseHeaders and risks drift; replace the custom checks by delegating to the shared auth validator (or refactor the common logic into a new Middlewares.validateParseHeaders or similar) so header parsing, master-key loading (Config.loadMasterKey), and IP checks (Middlewares.checkIp) and their error handling are centralized; update _earlyHeadersMiddleware to call that shared validator and propagate/return the resulting sanitized HTTP error responses (status and JSON) instead of reimplementing the checks locally, ensuring identical logging and future behavior.package.json (1)
51-51: Suggested PR title for changelog clarity
feat(files): allow per-upload maxUploadSize override in Parse.FileBased on learnings: For Parse Server PRs, suggest an Angular commit convention PR title using
type(scope): description.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 51, Update the PR title to follow the Angular commit convention and be descriptive: use "feat(files): allow per-upload maxUploadSize override in Parse.File" as the PR/commit title; ensure the scope is "files" and the subject references "Parse.File" and the ability to override maxUploadSize per upload so changelogs and package updates (e.g., related to the "parse": "8.5.0" dependency change) pick up the feature correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Routers/FilesRouter.js`:
- Around line 291-298: The code uses the logical OR operator and thus treats a
zero-valued override as falsy; update the two instances that read
req._maxUploadSizeOverride in FilesRouter (the branch that sets
req._maxUploadSizeBytes and the branch that computes limit) to use the nullish
coalescing operator (??) instead of || so an explicit 0 override is preserved
(keep defaultMaxBytes from parseSizeToBytes and maxUploadSize as the fallback
values).
---
Nitpick comments:
In `@package.json`:
- Line 51: Update the PR title to follow the Angular commit convention and be
descriptive: use "feat(files): allow per-upload maxUploadSize override in
Parse.File" as the PR/commit title; ensure the scope is "files" and the subject
references "Parse.File" and the ability to override maxUploadSize per upload so
changelogs and package updates (e.g., related to the "parse": "8.5.0" dependency
change) pick up the feature correctly.
In `@src/Routers/FilesRouter.js`:
- Around line 238-246: Add a short README entry documenting the new per-request
upload size override (header `X-Parse-File-Max-Upload-Size`) and how to use it
(requires master key, same format as server option like "50mb"/"1gb", and maps
to `req._maxUploadSizeOverride` used by `_bodyParsingMiddleware`), referencing
FilesRouter middleware behavior in `FilesRouter.js` so users can discover the
feature and its security requirement.
- Around line 247-273: This inline master-key/IP validation in
_earlyHeadersMiddleware duplicates logic from Middlewares.handleParseHeaders and
risks drift; replace the custom checks by delegating to the shared auth
validator (or refactor the common logic into a new
Middlewares.validateParseHeaders or similar) so header parsing, master-key
loading (Config.loadMasterKey), and IP checks (Middlewares.checkIp) and their
error handling are centralized; update _earlyHeadersMiddleware to call that
shared validator and propagate/return the resulting sanitized HTTP error
responses (status and JSON) instead of reimplementing the checks locally,
ensuring identical logging and future behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 433d7a16-858e-4eb6-bc9a-b9097fa599be
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
package.jsonspec/ParseFile.spec.jssrc/Routers/FilesRouter.js
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10093 +/- ##
==========================================
- Coverage 92.63% 92.22% -0.42%
==========================================
Files 191 191
Lines 15804 15831 +27
Branches 180 180
==========================================
- Hits 14640 14600 -40
- Misses 1152 1215 +63
- Partials 12 16 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 4, 2026
# [9.5.0-alpha.2](9.5.0-alpha.1...9.5.0-alpha.2) (2026-03-04) ### Features * Add `Parse.File` option `maxUploadSize` to override the Parse Server option `maxUploadSize` per file upload ([#10093](#10093)) ([3d8807b](3d8807b))
Contributor
|
🎉 This change has been released in version 9.5.0-alpha.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Add
Parse.FileoptionmaxUploadSizeto override the Parse Server optionmaxUploadSizeper file uploadTasks
Summary by CodeRabbit
New Features
Tests
Chores