fix: PagesRouter path traversal allows reading files outside configured pages directory (GHSA-hm3f-q6rw-m6wh)#10104
Conversation
|
I will reformat the title to use the proper commit message syntax. |
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughThese changes add a security test for path traversal attacks and harden the path validation logic in PagesRouter to prevent access to sibling directories with shared name prefixes by requiring an explicit path separator after the pagesPath. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PagesRouter path traversal allows reading files outside configured pages directory (GHSA-hm3f-q6rw-m6wh)
# [9.5.0-alpha.8](9.5.0-alpha.7...9.5.0-alpha.8) (2026-03-05) ### Bug Fixes * `PagesRouter` path traversal allows reading files outside configured pages directory ([GHSA-hm3f-q6rw-m6wh](https://github.com/parse-community/parse-server/security/advisories/GHSA-hm3f-q6rw-m6wh)) ([#10104](#10104)) ([e772543](e772543))
|
🎉 This change has been released in version 9.5.0-alpha.8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10104 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 191 191
Lines 15856 15856
Branches 180 180
=======================================
Hits 14694 14694
Misses 1150 1150
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Issue
PagesRouterpath traversal allows reading files outside configured pages directory (GHSA-hm3f-q6rw-m6wh)Tasks
Summary by CodeRabbit
Tests
Bug Fixes