test: LiveQuery disconnect does not clear subscription info

[mtrezza]

Issue

LiveQuery disconnect does not clear subscription info

Tasks

• Add new tests
• Add changes to documentation (guides, repository pages, in-code descriptions)

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d59f06b5-815d-4044-af22-00c5fe729219

📥 Commits

Reviewing files that changed from the base of the PR and between 4c6a59a and 1d44066.

📒 Files selected for processing (1)

• spec/ParseLiveQueryServer.spec.js

✅ Files skipped from review due to trivial changes (1)

• spec/ParseLiveQueryServer.spec.js

---

📝 Walkthrough

Walkthrough

Added a Jasmine test that exercises the server's registered disconnect behavior: it simulates a client websocket disconnect and asserts the client is removed from parseLiveQueryServer.clients and that client.deleteSubscriptionInfo() is not called.

Changes

Cohort / File(s)	Summary
Disconnect Handler Test spec/ParseLiveQueryServer.spec.js	Replaced a TODO with a concrete test: constructs a ParseLiveQueryServer, attaches a mock EventEmitter websocket (with clientId), registers handlers via _onConnect(...), adds a mock subscription, emits disconnect, asserts the client is removed from parseLiveQueryServer.clients and that client.deleteSubscriptionInfo(...) is not invoked.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, but one is expected according to the repository template.	Add a description following the template, including sections for Issue, Approach, and Tasks checklist to document the purpose and scope of this test addition.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title begins with 'test:' prefix as required and clearly describes the test addition for LiveQuery disconnect behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check	✅ Passed	The pull request introduces a security verification test that correctly confirms a vulnerability does not exist by verifying the disconnect handler does not incorrectly call deleteSubscriptionInfo().
Engage In Review Feedback	✅ Passed	The PR is open with no reviewers assigned, so review feedback has not yet been provided. The commit is focused with clear intent for testing disconnect handler behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@spec/ParseLiveQueryServer.spec.js`:
- Around line 660-673: The test currently only asserts that
client.deleteSubscriptionInfo was not called after emitting 'disconnect', which
can pass if the disconnect listener never ran; modify the spec to also assert a
positive side-effect of the disconnect handler so the handler actually executed:
after calling addMockSubscription(parseLiveQueryServer, clientId, requestId,
parseWebSocket) and parseLiveQueryServer._onConnect(parseWebSocket) then emit
'disconnect' and add a positive expectation such as verifying
parseLiveQueryServer._connectedClients no longer contains clientId (or that
parseWebSocket.connected flag changed, or that a mock disconnect handler spy was
called) to prove the disconnect listener ran while keeping the existing assert
that client.deleteSubscriptionInfo was not called; reference symbols:
addMockSubscription, parseLiveQueryServer._onConnect,
parseWebSocket.emit('disconnect'), client.deleteSubscriptionInfo.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86f2d7a1-cd50-421c-9549-3116715eefc3

📥 Commits

Reviewing files that changed from the base of the PR and between f184f76 and 4c6a59a.

📒 Files selected for processing (1)

• spec/ParseLiveQueryServer.spec.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.98%. Comparing base (c0889c8) to head (1d44066).
⚠️ Report is 6 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10414      +/-   ##
==========================================
- Coverage   83.98%   83.98%   -0.01%     
==========================================
  Files         192      192              
  Lines       16749    16749              
  Branches      229      229              
==========================================
- Hits        14067    14066       -1     
- Misses       2656     2657       +1     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.8.0-alpha.11