-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
docs: Fix docs generation #9899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix docs generation #9899
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughUpdated JSDoc source include paths from Changes
Sequence Diagram(s)sequenceDiagram
participant User as Developer (manual trigger)
participant GH as GitHub Actions
participant Repo as Repository
participant Runner as Actions Runner (ubuntu)
participant Node as Node.js env
participant Script as release_docs.sh
participant GH_Pages as GitHub Pages (peaceiris)
rect rgb(235,245,255)
User->>GH: Manually trigger release-manual-docs.yml (input: ref)
GH->>Runner: Start `docs` job (checkout specified ref)
Runner->>Repo: actions/checkout@v4 at provided ref
end
rect rgb(245,255,235)
Runner->>Node: Setup Node.js v18.20.4
Runner->>Runner: Restore npm cache (lockfile key)
Runner->>Runner: Run `npm ci`
Runner->>Script: Execute `release_docs.sh` (env: SOURCE_TAG=ref)
Script->>Runner: Generate docs into ./docs
end
rect rgb(255,245,235)
Runner->>GH_Pages: peaceiris/actions-gh-pages deploy (`./docs`, GITHUB_TOKEN)
GH_Pages-->>Runner: Publish result
Runner-->>GH: Job complete (success/failure)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release-manual-docs.yml (2)
9-12: Remove redundant default value when input is required.The
refinput hasrequired: truewhich means it must be provided at workflow trigger time. Thedefault: ''is therefore unreachable and adds unnecessary confusion.Apply this diff to remove the redundant default:
ref: - default: '' description: 'Reference (tag / SHA):' required: true
33-39: Clarify the purpose of echoing the SOURCE_TAG variable.The
echo $SOURCE_TAGon line 35 appears to be debug output, but it's unclear if this is intentional. If used for logging/traceability, consider documenting the purpose; otherwise, consider removing it to reduce log verbosity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release-manual-docs.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/release-manual-docs.yml (2)
1-44: Workflow structure is sound.The workflow follows GitHub Actions best practices:
- Action versions are pinned for reproducibility (checkout@v4, setup-node@v4, cache@v4).
- Node.js version is pinned (18.20.4).
- Timeout is reasonable for docs generation (15 minutes).
- Secrets handling is secure (uses built-in GITHUB_TOKEN).
- Clear documentation in the header comments.
18-44: All workflow prerequisites verified and in place.The
release_docs.shscript exists, is executable, properly uses theSOURCE_TAGenvironment variable, and correctly generates and populates the./docsdirectory for deployment. The workflow is properly configured.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #9899 +/- ##
==========================================
+ Coverage 92.98% 92.99% +0.01%
==========================================
Files 187 187
Lines 15177 15177
Branches 177 177
==========================================
+ Hits 14112 14114 +2
+ Misses 1053 1051 -2
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Chores
New Features