Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Nov 9, 2025

Pull Request

Issue

Performance tests shows high variance due to unpredictable VM resources.

Approach

Various optimizations.

Summary by CodeRabbit

  • Chores
    • Enhanced performance testing infrastructure with increased benchmark iteration counts for more accurate measurements.
    • Adjusted performance regression detection thresholds to improve sensitivity in identifying performance changes.
    • Updated benchmark documentation to reflect new testing parameters.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 9, 2025

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request increases performance benchmark iterations from 1,000 to 10,000 across the benchmark suite and CI workflow, adjusts performance regression thresholds in CI comparisons (50%→25%, 100%→50%, -50%→-25%), and updates documentation accordingly.

Changes

Cohort / File(s) Summary
Performance Benchmark Configuration
.github/workflows/ci-performance.yml, benchmark/performance.js, CONTRIBUTING.md
Increased default benchmark iterations from 1,000 to 10,000; adjusted performance change thresholds in CI workflow comparisons (threshold values halved); removed per-benchmark iteration overrides; updated documentation and PR comment generation to reflect new iteration count and thresholds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward numeric constant adjustments with minimal logic density
  • Changes are homogeneous and repetitive (all focused on iteration counts and threshold values)
  • Configuration and documentation updates with no complex control flow modifications

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d94f348 and d1dd2f8.

📒 Files selected for processing (3)
  • .github/workflows/ci-performance.yml (2 hunks)
  • CONTRIBUTING.md (1 hunks)
  • benchmark/performance.js (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mtrezza mtrezza merged commit 36e166c into parse-community:alpha Nov 9, 2025
22 of 25 checks passed
@mtrezza mtrezza deleted the ci/perf-fix branch November 9, 2025 12:30
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (d94f348) to head (d1dd2f8).
⚠️ Report is 2 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9925   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files         187      187           
  Lines       15224    15224           
  Branches      177      177           
=======================================
  Hits        14170    14170           
  Misses       1042     1042           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants