-
-
Notifications
You must be signed in to change notification settings - Fork 157
fix cross builds #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cross builds #1479
Conversation
remove x86_64 configuration from cross.toml as we dont need cross updated release.yml to use cross only for aarch64 linux builds
WalkthroughThe PR simplifies cross-compilation configuration by restructuring the Linux build matrix in the release workflow to use explicit include entries with per-target cross-compilation flags, and removes pre-build/environment setup from Cross.toml, retaining only the image specification. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (3)
Comment |
remove x86_64 configuration from cross.toml as we dont need cross
updated release.yml to use cross only for aarch64 linux builds
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.