-
-
Notifications
You must be signed in to change notification settings - Fork 157
update action versions in kafka image build #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update action versions in kafka image build #1490
Conversation
WalkthroughGitHub Actions workflow for edge Kafka builds updated with bumped action versions (docker/login-action, docker/metadata-action, docker/build-push-action), addition of a builder cache cleanup step, and removal of a previous cleanup step. Build arguments and platform targets remain aligned for amd64 and arm64 builds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-push-edge-kafka.yaml (1)
40-42: Cache cleanup before builds will discard layer caching benefits.Running
docker builder prune -fbefore the build steps will clear all cached layers, which may significantly increase build times by forcing a rebuild from scratch on each run. While this is useful for managing disk space on self-hosted runners, it trades off build performance.Consider whether this timing is optimal, or if selective cache cleanup would be more appropriate (e.g., using
--filteror--keep-storageoptions).You may want to benchmark the build times before and after this change to assess the performance impact.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-push-edge-kafka.yaml(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nikhilsinhaparseable
Repo: parseablehq/parseable PR: 1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
📚 Learning: 2025-04-26T03:58:02.341Z
Learnt from: nikhilsinhaparseable
Repo: parseablehq/parseable PR: 1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
Applied to files:
.github/workflows/build-push-edge-kafka.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: coverage
🔇 Additional comments (4)
.github/workflows/build-push-edge-kafka.yaml (4)
54-63: LGTM!The aarch64 build configuration is consistent with the x86_64 build, with appropriate platform and build argument adjustments.
28-32: Verify that docker/login-action@v3 is the latest version.Confirm this is the most recent stable version to ensure latest security patches and features are included.
43-52: No action needed. docker/build-push-action@v6 is the latest stable release.
34-38: docker/metadata-action@v5 is appropriately configured and will automatically receive updates.The latest version of docker/metadata-action is v5.10.0, and the workflow's use of the @v5 tag follows best practice by automatically receiving patch and minor version updates within the v5 release series. No action needed.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.