test: guard large table rendering#45
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
renderTablecan process 150,000 sessions without overflowing the JavaScript call stack and keeps every rendered row aligned when the widest value appears at the end of the input.This guards merged PR #12's single-pass width calculation against regression to the former
Math.max(...matrix)implementation, which throwsRangeError: Maximum call stack size exceededat this input size.Test files updated
test/format.test.tsWhy this materially reduces regression risk
The existing small fixtures and excluded benchmark both pass if the old spread-based implementation returns. The new deterministic test exercises the actual large-input failure mode without timing assertions or external dependencies. A mutation check confirmed that restoring the old implementation makes this test fail with the expected
RangeError.Validation
npm test— 36/36 passednpm run build— passednpx prettier --check test/format.test.ts— passed