Skip to content

fix(ide): align inactive branch semantics#234

Merged
hongjr03 merged 1 commit into
feat/preproc-provenance-chainfrom
fix/inactive-branch-semantics
Jun 5, 2026
Merged

fix(ide): align inactive branch semantics#234
hongjr03 merged 1 commit into
feat/preproc-provenance-chainfrom
fix/inactive-branch-semantics

Conversation

@hongjr03
Copy link
Copy Markdown
Member

@hongjr03 hongjr03 commented Jun 5, 2026

Closes #233.

Summary

  • use the per-file effective preprocess config when building syntax options for file-scoped IDE/HIR queries
  • parse HIR semantic files through the include-aware compilation parse path so included macro definitions select the same ifdef branch for diagnostics, navigation, and semantic tokens
  • add regressions for both manifest predefines and included-header defines driving inactive branch behavior

Validation

  • cargo test -p hir preproc -- --nocapture
  • cargo test -p ide preproc -- --nocapture
  • cargo test -p ide included_macro_selects_same_ifdef_branch_for_diagnostics_navigation_and_tokens -- --nocapture
  • cargo test -p ide verilog_2005 -- --nocapture
  • cargo fmt --check
  • git diff --check

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Docs preview: https://vide.pascal-lab.net/preview/pr-234/

@hongjr03 hongjr03 force-pushed the fix/inactive-branch-semantics branch from 587e25d to 48c0c11 Compare June 5, 2026 12:23
@hongjr03 hongjr03 changed the base branch from master to feat/preproc-provenance-chain June 5, 2026 12:24
@hongjr03 hongjr03 force-pushed the fix/inactive-branch-semantics branch 4 times, most recently from 136bf7b to 7f98c0a Compare June 5, 2026 14:12
@hongjr03 hongjr03 force-pushed the fix/inactive-branch-semantics branch from 7f98c0a to 9b77077 Compare June 5, 2026 14:28
@zhuguiyuan
Copy link
Copy Markdown

Cool!

@hongjr03 hongjr03 linked an issue Jun 5, 2026 that may be closed by this pull request
@hongjr03 hongjr03 merged commit 5711981 into feat/preproc-provenance-chain Jun 5, 2026
12 checks passed
@hongjr03 hongjr03 deleted the fix/inactive-branch-semantics branch June 5, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defines in header files are not resolved in source files

2 participants