Add project plugin management and extract Nature - #501
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 24016ad. Configure here.
| obj.installedPlugins.filter((id): id is string => typeof id === 'string'), | ||
| { explicit: true }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
MCP legacy load hides plugins
High Severity
Calling SceneBridge.setScene (e.g., from loadJSON) implicitly resets the store's installedPlugins state, as it only updates nodes and root IDs. This causes plugin nodes in loaded scenes (especially legacy graphs without explicit plugin data) to be treated as disabled by the new gating logic, making them invisible or non-functional in MCP.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 24016ad. Configure here.
| installedPlugins: parsed.installedPlugins ?? currentScene.installedPlugins, | ||
| hasExplicitPluginInstallState: | ||
| parsed.installedPlugins !== undefined || currentScene.hasExplicitPluginInstallState, | ||
| }, |
There was a problem hiding this comment.
Import inherits project plugins
Medium Severity
When importing a build JSON file, handleConfirmImport uses parsed.installedPlugins ?? currentScene.installedPlugins. This causes files that omit installedPlugins to inherit the current project's plugin state, rather than applying default or legacy rules as cloud load does. Consequently, imported plugin nodes may be incorrectly hidden, visible, or disabled.
Reviewed by Cursor Bugbot for commit 24016ad. Configure here.
| ? installedPlugins.filter((id) => id !== pluginId) | ||
| : [...installedPlugins, pluginId] | ||
| setInstalledPlugins(next, { explicit: true }) | ||
| }} |
There was a problem hiding this comment.
Uninstall leaves active placement tool
Medium Severity
Uninstalling a plugin updates its installed status but fails to deactivate any active placement tools. This allows users to create invisible nodes in the scene, as the plugin's rendering and systems are no longer active.
Reviewed by Cursor Bugbot for commit 24016ad. Configure here.
| const { nodes, rootNodeIds, collections, materials } = state | ||
| return { nodes, rootNodeIds, collections, materials } | ||
| const { nodes, rootNodeIds, collections, materials, installedPlugins } = state | ||
| return { nodes, rootNodeIds, collections, materials, installedPlugins } |
There was a problem hiding this comment.
Undo skips explicit plugin flag
Medium Severity
Temporal undo/redo tracks installedPlugins but not hasExplicitPluginInstallState. Restoring an older plugin list after install changes can leave the explicit flag out of sync with the undone list, so default-install merging and export semantics no longer match user expectation.
Reviewed by Cursor Bugbot for commit 24016ad. Configure here.
1 participant
Summary
Test plan
Related
Note
Medium Risk
Changes scene document shape and rendering gating across core, editor, and viewer; legacy scenes rely on omitted
installedPluginsmeaning “show loaded plugins,” which must stay correct on load/save round-trips.Overview
Adds per-project plugin installation: scenes carry
installedPlugins, with install/uninstall in a new Plugins sidebar (list + detail). Uninstall hides plugin panels, tools, renderers, systems, and floorplan output viaisNodeKindEnabled, but plugin nodes stay in the graph and come back when the plugin is reinstalled.Persistence threads
installedPluginsthrough autosave, API graph validation, import/export, cloning/forking, scene load signatures, undo, and MCP export/load (legacy graphs without the field keep backward-compatible behavior).Nature (
@pascal-app/plugin-trees) moves out of the monorepo topascalorg/plugin-treesat a pinned GitHub commit; the in-tree package is removed. Docs and CONTRIBUTING/README now point at the hosted plugin guide and external example repo.EditorHostPanelgains optional metadata (pluginId,defaultInstalled, creator URLs) for the manager UI.Reviewed by Cursor Bugbot for commit 24016ad. Bugbot is set up for automated code reviews on this repo. Configure here.