Terrain sculpting and terrain-aware vertical editing - #564
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 658ce25. Configure here.
| echo "NPM_TAG=beta" >> "$GITHUB_ENV" | ||
| else | ||
| echo "NPM_TAG=latest" >> "$GITHUB_ENV" | ||
| fi |
There was a problem hiding this comment.
Beta publish can tag latest
High Severity
NPM_TAG is set to beta only when bump is beta; every other bump, including none, publishes with --tag latest. After packages are on 1.0.0-beta.N, a none republish would mark that prerelease as latest. Non-beta bumps also parse 1.0.0-beta.1 into a broken patch segment and fail in arithmetic.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 658ce25. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
1.0.0-beta.Nversioning and the npmbetadist-tag while preservinglatestVerification
bun run checkbun run check-typesbun test packages/core/src(917 pass)bun test packages/editor/src packages/nodes/src packages/viewer/src apps/editor(1,588 pass, 1 skipped)bun run buildNote
High Risk
Touches core elevation, spatial-grid sync, and scene persistence for terrain—bugs could mis-place structures or desync live sculpt from committed geometry; release workflow changes affect how packages are published.
Overview
Ships 1.0.0-beta.1 documentation and release plumbing: a
betabump path inrelease.yml(prerelease versions,npm publish --tag beta), rootrelease:beta, and a changelog entry describing the beta scope.Introduces a persistent terrain heightfield in core (codec, brush strokes with live preview via
useLiveTerrain, raycast, cachedterrainFieldOf/commitTerrainField) and wires the editor Build → Terrain flow toterrain-sculptmode withTerrainSculptPaneland sculpt tooling.Makes the scene terrain-aware vertically: floor-placed nodes and walls treat the level base as sampled ground (
terrainSupportLift,GROUND_SUPPORT_ID), slab support elections usegetSlabSupportForItem, walls gain ground-hosted base elevation withsupportOffset, and spatial-grid sync re-dirties grade-level dependents when terrain commits or live dabs change. Auto-room slabs/ceilings can align to enclosing wall construction planes when walls agree.Also refactors slab-change dirty marking into
markSlabChangeDependentsand exports the new terrain/support APIs from@pascal-app/core.Reviewed by Cursor Bugbot for commit 658ce25. Bugbot is set up for automated code reviews on this repo. Configure here.