fix(ifc): avoid merging adjacent wall assemblies - #603
Open
yorhodes wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1cbf8d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Scope
This is the cleanup-only follow-up requested in the review of #553. It changes only the IFC cleanup implementation and its tests.
Fixture wall counts
The same unsimplified converted nodes were passed through main and this branch:
For Paris, merged groups change from 15 to 8 and removed merged walls from 28 to 13. The stricter behavior intentionally preserves ambiguous wall assemblies for later inspection instead of joining nearby centerlines.
Verification
Note
Medium Risk
Changes post-conversion scene topology (fewer merged walls on real fixtures like Paris), which can affect downstream geometry and editing but is confined to the IFC simplification step with explicit regression tests.
Overview
IFC scene-graph cleanup now merges collinear wall fragments less aggressively, so adjacent parallel assemblies and mismatched materials stay separate.
Centerline tolerance in
wallLineTolerancedrops from ~half wall thickness to ~10% (capped ~5–25 mm), so fragments offset by a couple of inches no longer collapse into one wall.Material gating adds
wallMaterialSignature/wallMaterialCompatibleonmetadata.materialandmetadata.materialLayers; tagged vs untagged walls are incompatible, while identical layer assemblies can still merge.wallsCanMergeenforces this before interval checks.Regression tests cover offset centerlines, material/layer boundaries, and matching-layer merges.
Reviewed by Cursor Bugbot for commit 0024b1e. Bugbot is set up for automated code reviews on this repo. Configure here.