core: reconcile room surfaces after wall topology edits - #624
Merged
wass08 merged 40 commits intoAug 11, 2026
Conversation
Items (e.g. solar panels) can now be placed on sloped roof surfaces. The placement system computes euler rotation from the roof surface normal so items sit flush on the slope instead of going inside. - Add roofStrategy to placement-strategies with enter/move/click/leave - Wire roof:enter/move/click/leave events in the placement coordinator - Add calculateRoofRotation in placement-math using surface normals - Support full 3D cursor rotation for sloped surfaces - Items on roofs are parented to the level with world-space rotation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… github.com:pascalorg/editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #544
Incorporates the implementation and review feedback discussed in #554.
How to test
bun run check-types,bun run build,bun run check, andbun test; all should pass.bun dev, open a saved scene, switch to 2D, create a four-wall room, and customize its auto slab thickness, elevation, or material.Screenshots / screen recording
Not included — this changes topology reconciliation behavior rather than visual styling. The browser steps above reproduce the interactive result.
Checklist
bun devbun checkto verify)mainbranchNote
High Risk
Touches core room detection, auto surface lifecycle, and collaborative commit boundaries—bugs could duplicate/miss slabs, corrupt openings, or desync remote clients.
Overview
Introduces
planWallInsertionandplanWallSplitAtPointin core so wall draws can commit crossings, host splits, attachment moves, curved intersections, and terrain rebasing as one atomic change set instead of piecemeal edits.Space detection now keeps a per-level
RoomTopologyIndexand, when a commit reports changed wall IDs, reconciles only the connected wall component: spaces, wall sides, zones, and auto slabs/ceilings. Incompatible merged auto surfaces are demoted to manual rather than forced together; compatible merges/splits preserve materials, holes (including clipped stair/elevator openings), recessed slab settings, and ceiling children with reparent plans. Scenes loaded without auto surfaces no longer get backfilled slabs/ceilings on later reshapes; user-deleted generated surfaces stay suppressed.Scene mutations record
changedNodeIdson commits (runWithSceneCommitNodeIdsin node actions) so detection runs in the same history step as the wall edit and remote/load baselines resync via commit subscription. Large test coverage compares indexed vs full reconciliation and wall-topology edge cases.Reviewed by Cursor Bugbot for commit 5567070. Bugbot is set up for automated code reviews on this repo. Configure here.