Skip to content

Wall batch test: drive the frame function directly - #763

Merged
wass08 merged 1 commit into
mainfrom
fix/wall-batch-test-harness
Sep 4, 2026
Merged

Wall batch test: drive the frame function directly#763
wass08 merged 1 commit into
mainfrom
fix/wall-batch-test-harness

Conversation

@wass08

@wass08 wass08 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

The wall batch test harness (added in #761) rendered WallBatchSystem through react-dom/server to capture the useFrame callback. react-dom is not resolvable from packages/nodes in the private monorepo's install, so its CI could not load the file (Cannot find module 'react-dom/server'). The frame function is now exported and the test calls it directly; the fiber mock goes away with the render.

bun test packages/nodes: 1 909 pass. Repo-wide biome clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jmmz2AMwTzcnKsSHHPEMhN


Note

Low Risk
Test-only refactor plus exporting an existing internal frame helper; production behavior is unchanged aside from the public export.

Overview
Fixes CI failures in packages/nodes where wall batch tests could not load because they depended on react-dom/server, which is not resolvable from that package’s install.

runBatchFrame is now exported from wall-batch-system.tsx (the same function WallBatchSystem already invokes from useFrame). The test harness calls it through a small runFrame wrapper with a noop invalidate and a wakeRef, instead of rendering the React component via SSR to capture the fiber useFrame callback.

The @react-three/fiber mock, react-dom/server, and related setup/teardown around frameCallback are removed; batch setup still advances simulated time and runs two frames to create the merged wall-batch mesh.

Reviewed by Cursor Bugbot for commit 9e8fb6f. Bugbot is set up for automated code reviews on this repo. Configure here.

The harness rendered the system with react-dom/server to capture the
useFrame callback; react-dom is not resolvable from the nodes package in
the private monorepo's install, so its CI could not load the file.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jmmz2AMwTzcnKsSHHPEMhN
@pascal

pascal Bot commented Sep 4, 2026

Copy link
Copy Markdown

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: 5bbf366a-41eb-4fdb-a239-4616744104e8

@wass08
wass08 merged commit eaf492c into main Sep 4, 2026
3 checks passed
@wass08
wass08 deleted the fix/wall-batch-test-harness branch September 4, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant