Wall batch test: drive the frame function directly - #763
Merged
Conversation
The harness rendered the system with react-dom/server to capture the useFrame callback; react-dom is not resolvable from the nodes package in the private monorepo's install, so its CI could not load the file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jmmz2AMwTzcnKsSHHPEMhN
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 5bbf366a-41eb-4fdb-a239-4616744104e8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wall batch test harness (added in #761) rendered
WallBatchSystemthroughreact-dom/serverto capture theuseFramecallback.react-domis not resolvable frompackages/nodesin the private monorepo's install, so its CI could not load the file (Cannot find module 'react-dom/server'). The frame function is now exported and the test calls it directly; the fiber mock goes away with the render.bun test packages/nodes: 1 909 pass. Repo-wide biome clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Jmmz2AMwTzcnKsSHHPEMhN
Note
Low Risk
Test-only refactor plus exporting an existing internal frame helper; production behavior is unchanged aside from the public export.
Overview
Fixes CI failures in
packages/nodeswhere wall batch tests could not load because they depended onreact-dom/server, which is not resolvable from that package’s install.runBatchFrameis now exported fromwall-batch-system.tsx(the same functionWallBatchSystemalready invokes fromuseFrame). The test harness calls it through a smallrunFramewrapper with a noopinvalidateand awakeRef, instead of rendering the React component via SSR to capture the fiberuseFramecallback.The
@react-three/fibermock,react-dom/server, and related setup/teardown aroundframeCallbackare removed; batch setup still advances simulated time and runs two frames to create the mergedwall-batchmesh.Reviewed by Cursor Bugbot for commit 9e8fb6f. Bugbot is set up for automated code reviews on this repo. Configure here.