Fix resize handle drag behavior#179
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ruler resize-handle dragging to resize the window frame directly (instead of relying on background dragging), while keeping grouped/child window frames stable during the drag, and adds unit tests to validate the resize math and interaction behavior.
Changes:
- Implement explicit resize-drag handling in
ResizeHandleView(track mouse down/drag/up, compute new window frame, suppress background dragging, preserve child window frames during drag). - Add core tests covering resize frame math (clamping + fixed edges) and background dragging suppression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FreeRulerTests/RulerCoreTests.swift | Adds tests for resize frame math and for disabling/restoring background dragging during resize-handle drags. |
| Free Ruler/ResizeHandleView.swift | Implements resize-handle-driven window resizing, cursor handling, accessibility identifiers, and child-window frame preservation during drags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pascalpp
force-pushed
the
codex/173-resize-handle
branch
from
867970e to
7f53bfd
Compare
pascalpp
force-pushed
the
codex/177-resize-handle-drag
branch
from
53573bf to
7ae1360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177
Summary
Tests