Skip to content

SubscribeMetadata dont hold a list of methods for events#702

Merged
DavidBadura merged 3 commits into
4.0.xfrom
subscribe-metadata-no-method-list-subscribe
Jun 27, 2025
Merged

SubscribeMetadata dont hold a list of methods for events#702
DavidBadura merged 3 commits into
4.0.xfrom
subscribe-metadata-no-method-list-subscribe

Conversation

@DanielBadura

@DanielBadura DanielBadura commented Feb 19, 2025

Copy link
Copy Markdown
Member

As mentioned in #701 this PR adjusts the API so that the metadata isnt holding a list of methods for an event anymore as this is not supported.

@DanielBadura
DanielBadura changed the base branch from 3.11.x to dont-allow-subcribe-double-event February 19, 2025 13:56
@DanielBadura DanielBadura added this to the 4.0.0 milestone Feb 19, 2025
@DanielBadura DanielBadura self-assigned this Feb 19, 2025
@DanielBadura DanielBadura changed the title Subscribe metadata no method list subscribe SubscribeMetadata dont hold a list of methods for events Feb 19, 2025
@github-actions

github-actions Bot commented Feb 19, 2025

Copy link
Copy Markdown

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.333ms (±0.00%)   | 4.345ms (±0.00%)   | -0.29%    | 37.651mb        | 38.184mb   | -1.40%      |
| benchSave10000Events () | 334.819ms (±0.00%) | 357.475ms (±0.00%) | -6.34%    | 37.724mb        | 38.256mb   | -1.39%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 993.200μs (±0.00%) | 1.086ms (±0.00%)   | -8.54%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchLoad10000Events ()                | 56.817ms (±0.00%)  | 58.742ms (±0.00%)  | -3.28%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave1Event ()                     | 1.061ms (±0.00%)   | 1.033ms (±0.00%)   | +2.66%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Events ()                | 288.379ms (±0.00%) | 292.488ms (±0.00%) | -1.40%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.392s (±0.00%)    | 8.399s (±0.00%)    | -0.08%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.044s (±0.00%)    | 5.068s (±0.00%)    | -0.47%    | 34.458mb        | 34.458mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.153s (±0.00%) | 3.156s (±0.00%) | -0.09%    | 46.961mb        | 46.961mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 959.900μs (±0.00%) | 960.500μs (±0.00%) | -0.06%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchLoad10000Events ()                | 53.933ms (±0.00%)  | 54.084ms (±0.00%)  | -0.28%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave1Event ()                     | 1.000ms (±0.00%)   | 993.100μs (±0.00%) | +0.71%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Events ()                | 216.366ms (±0.00%) | 213.631ms (±0.00%) | +1.28%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.109s (±0.00%)    | 8.209s (±0.00%)    | -1.21%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.847s (±0.00%)    | 4.871s (±0.00%)    | -0.49%    | 34.344mb        | 34.344mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 74.348ms (±0.00%) | 75.003ms (±0.00%) | -0.87%    | 34.813mb        | 34.813mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 52.681ms (±0.00%)  | 51.552ms (±0.00%)  | +2.19%    | 34.419mb        | 34.419mb   | 0.00%       |
| benchLoad10000Events ()                | 890.200μs (±0.00%) | 875.100μs (±0.00%) | +1.73%    | 34.418mb        | 34.418mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 896.700μs (±0.00%) | 878.400μs (±0.00%) | +2.08%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchLoad10000Events ()                | 92.124ms (±0.00%)  | 95.020ms (±0.00%)  | -3.05%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave1Event ()                     | 1.467ms (±0.00%)   | 1.682ms (±0.00%)   | -12.79%   | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000Events ()                | 250.372ms (±0.00%) | 251.005ms (±0.00%) | -0.25%    | 35.550mb        | 35.550mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.468s (±0.00%)   | 12.470s (±0.00%)   | -0.01%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.029s (±0.00%)    | 9.045s (±0.00%)    | -0.17%    | 36.050mb        | 36.050mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura

Copy link
Copy Markdown
Member Author

Not sure why no BC-Break is here detected.

Base automatically changed from dont-allow-subcribe-double-event to 3.10.x February 21, 2025 11:20
@DanielBadura DanielBadura linked an issue Mar 3, 2025 that may be closed by this pull request
@DavidBadura
DavidBadura changed the base branch from 3.10.x to 4.0.x June 27, 2025 08:27
@DavidBadura
DavidBadura force-pushed the subscribe-metadata-no-method-list-subscribe branch from 5d086ef to 12ad717 Compare June 27, 2025 11:08
@DavidBadura
DavidBadura marked this pull request as ready for review June 27, 2025 11:08
@DavidBadura
DavidBadura merged commit 0f9b5e1 into 4.0.x Jun 27, 2025
40 checks passed
@DavidBadura
DavidBadura deleted the subscribe-metadata-no-method-list-subscribe branch June 27, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow Subscriber listening on the same event multiple times

2 participants