Fix Release to Publish cascade so releases actually publish to npm#55
Merged
Conversation
…elease event The Release workflow creates the GitHub release with the built-in GITHUB_TOKEN, and GitHub deliberately does not fire release-triggered workflows for those releases (anti-recursion), so Publish never ran and nothing reached npm. Bridge the two via workflow_dispatch, which is exempt from that rule: Release now dispatches Publish with the computed version, and Publish gains a `version` input that publishes the matching tag (blank input still does a dry-run). The release-event trigger stays for manual, human-created releases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Publish workflow now correctly handles both release and manual dispatch inputs. 🎯 Quality: 95% Elite · 📦 Size: Small 📈 This month: Your 219th PR — above team average · Averaging Excellent |
Contributor
Author
|
/review |
mariojgt
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Releaseworkflow creates the GitHub release with the built-inGITHUB_TOKEN, and GitHub deliberately does not firerelease-triggered workflows for those releases (an anti-recursion safeguard) — which is why v0.3.7 was cut butPublishnever ran and npm stayed on 0.3.6. This bridges the two workflows viaworkflow_dispatch, the one event type exempt from that rule:Releasenow dispatchesPublishwith the computed version, andPublishgains aversioninput that builds and publishes the matching tag (a blank input still does a dry-run). Therelease-event trigger stays in place for manual, human-created releases, which firePublishon their own. No new secrets or PATs required.🤖 Generated with Claude Code