[feat] surface remaining setup steps after scan + consistent guide labels#72
Merged
Conversation
…/Edit labels A) scan now prints a state-aware 'setup not complete' footer when steps remain (e.g. the package.json build hooks it can't wire itself), pointing at guide — closing the loop for agents that run scan but not guide and otherwise assume the widget + claim URL means done. B) the guide checklist labels every action consistently — 'Run →' for a command, 'Edit <file> →' for a hand-applied change, 'Note →' for context — and each todo names the actor, so an agent can tell 'run this' from 'edit this file' at a glance. Read-then-apply framing preserved. All prior asserted substrings kept; added label-regression assertions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Introduces clear user nudges and consistent guide labels. 🎯 Quality: 100% Elite · 📦 Size: Small 📈 This month: Your 88th PR — above team average · Averaging Excellent |
Contributor
Author
|
/review |
devlob
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the "half-finished setup" gap a real hosted-platform run exposed: an agent installed
@patchstack/connect, eventually ranscan(widget + claim URL appeared), and declared "done" — but thepackage.jsonbuild hooks were never wired, so future CI builds won't re-scan ormark-build. Two changes:A.
scannow surfaces what's left (src/cli.ts). After a scan, it computescountRemainingSteps(already imported) and, if any remain, prints:This closes the loop for the common case where an agent runs
scanbut notguideand otherwise assumes the widget + claim URL means it's finished. Best-effort (never fails a successful scan); self-suppressing once setup is complete.B.
guidechecklist uses consistent action labels (src/guide.ts). Previously the→prefix meant "run this", "edit this into a file", and plain prose — an agent couldn't tell execute from edit. Now every actionable line is labelled:Run →— a command to executeEdit <file> →— a change to apply and review by handNote →— context…and each todo headline names the actor ("Wire the build hooks yourself — edit package.json"). This keeps the read-then-apply / agent-as-reviewer framing (deliberately not more commanding — that would push toward the dictation refusals the field-test tracks).
Rendered:
Tests
npm run typecheck✓,npm test✓ (390 passed). Added assertions locking in theRun →/Edit package.json →labels so the scheme can't silently regress. All previously-asserted command/snippet substrings are preserved.Caveat (🟠 gated)
Both
guide.tsand thescanoutput are read live by agents. PerMAINTAINING.mdthis needs a field-test run, and the fixture installs the published package — so the behavior can only be exercised end-to-end after a publish. Validated here by typecheck, unit tests, and a real localguiderender.🤖 Generated with Claude Code