[refactor] pre-flight stops asking where to save; sharing is the only choice left - #214
Merged
Merged
Conversation
… choice left Even after #213 trimmed the save picker to one personal option, pre-flight still showed a 存到 section with a folder-shaped dropdown — a control whose only remaining personal choice was itself. The user's read was correct: if the customer decides filing, no folder control belongs on the meeting screen at all. The 存到 section is gone. Filing is the customer's folder (or the root with no customer) with nothing to choose; the one real decision left — share a copy to an org — is now its own row, shown only when signed in with sync on, and phrased as sharing rather than saving. The share is also independent of the customer now. The old override model made an org "save destination" beat the company link, silently dropping the local copy at the root — sharing to a team un-filed the customer's own recording. resolveMeetingSave now composes them: local filing always follows the customer; autoShare rides alongside. - meetingSaveOverride → meetingOrgShare ("off" suppresses a default share for one meeting; null follows the settings default) - SaveDestinationPicker → OrgSharePicker (off + orgs/org folders only) - Settings "default save location" becomes "auto-share to an organization"; the stored DefaultSaveLocation shape is unchanged, so existing org defaults keep working and personal ones mean "off" Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The 存到 section disappears from pre-flight. Filing follows the customer (or the root with no customer) — nothing to choose, so nothing is shown. The one real decision left, sharing a copy to an organization, becomes its own row (visible only when signed in with sync on) and a matching Settings entry retitled "auto-share to an organization".
Follow-up to #211/#213, prompted by user feedback on 0.22.6: even trimmed to one option, a folder-shaped dropdown on the meeting screen kept the retired model visible.
Why
Two reasons, one visible and one structural:
resolveMeetingSave, dropping the local copy at the personal root — sharing a customer's call with your team silently un-filed it from that customer. Sharing and filing are different questions; they now compose instead of competing:meetingSaveOverride→meetingOrgShare("off"suppresses a default share for one meeting;nullfollows the settings default).SaveDestinationPicker→OrgSharePicker. The storedDefaultSaveLocationshape is unchanged: existing org defaults keep auto-sharing, personal ones now simply mean "off".How it was verified
bunx tsc --noEmitpassesbunx vitest runpasses (329 tests; save-target suite rewritten — includes the regression test that sharing to an org keeps the customer's local filing)zh-TWanden; 12 orphaned keys pruned