[fix] onboarding: live-refresh permission status on focus - #36
Merged
Conversation
The permissions step only re-checked on entry, so after granting mic (or screen) access in the system prompt / System Settings, the row stayed stale until a manual re-check. Now it re-checks on window focus + visibilitychange, with a 2 s fallback poll while on the step (webview focus events aren't reliable across the app-switch to System Settings). microphone_status() reads the live AVCaptureDevice status, so the recheck reflects the grant immediately and the row flips to ✓.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the onboarding Permissions step, granting microphone (or screen-recording) access in the system prompt / System Settings didn't update the row — it stayed showing "not authorized" until you manually hit Re-check.
Cause
The step only re-checked permissions on entry (
useEffectkeyed onstep === 4). When you switch to System Settings, grant, and come back, nothing triggers a re-check.Fix
Re-check on window focus + visibilitychange, plus a 2 s fallback poll while on the step (webview focus events aren't fully reliable across the app-switch). The Rust
microphone_status()reads the liveAVCaptureDeviceauthorization status, so the re-check reflects the grant immediately and the row flips to ✓ on its own. The poll is torn down when leaving the step.Testing
bunx tsc --noEmitclean ·bun run buildsucceeds.