[feature] panel: key vault add/remove — masked secret entry, delete with confirm - #3
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
The panel's key vault view could only display keys and pointed at the CLI for everything else. It now manages them:
KeyRegistry::add— nowhere else; the field is cleared on submit and on failure.pb key addone-liner.Why relaxing "the panel never takes a secret" is sound
The CLI-only rule existed because argv leaks into
psand shell history. Neither applies to a masked field in a native window handing the value straight to the sameKeyRegistry::add. The line that actually matters is unchanged: the panel still never reads a value back — no reveal, no copy,get_secretstays unwired;pb key copyremains the only exit.docs/key-vault.mddocuments the split rationale.Also:
app/src-taurinow pins itself as a standalone cargo workspace, fixing builds from nested git worktrees (cargo walked up to the outer checkout's root and refused).Verification
bun run build(tsc + vite) green;cargo checkin src-tauri green from a nested worktree; clippy-D warningsclean on the Rust side; core registry behavior covered by patchbay-core's existing 28 vault tests (the panel adds no validation of its own — registry errors surface verbatim).