Skip to content

fix(io/tcp): TcpSocketOptionsValidator should validate the nested framing.maxLineLen #372

Description

@pathosDev

Post-merge review follow-up. TcpSocketOptionsValidator (src/io/broker/TcpSocketOptions.ts) does not validate the nested framing object — framing.maxLineLen <= 0 / NaN passes on the options path (the HOCON path only gets getInt type-checking). Since maxLineLen bounds the inbound line-framing buffer (security audit BRK-1), an invalid value silently defeats the cap. Add a nested-field rule (fail('framing.maxLineLen', …) for a positive integer).

Out of scope for the initial post-merge reconciliation (WP1–WP7); filed for later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpriority: lowNice-to-have / niche / demand-drivensecuritySecurity-relevant — see severity label for impact tierseverity: lowMinor / informational / mitigated-by-design

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions