Fix higher-order ID detection by checking IndexMap tuple IDs#324
Merged
Conversation
M-Lampert
approved these changes
Jul 20, 2026
M-Lampert
left a comment
M-Lampert
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good way to fix this problem temporarily. Feel free to merge it.
But I still think we should remove these functionalities from the base Graph-class once we have the HigherOrderGraph, since then no higher-order graphs should use the Graph-class but either EventGraph or HigherOrderGraph instead.
Collaborator
Author
|
Thanks @M-Lampert - let me merge this then, so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #323
Node/edge iteration and plotting decided whether IDs were tuples by checking
graph.order > 1. This PR bases the decision on the actual ID structure instead of graph order.Graph order and ID structure may not always coincide - in an upcoming
EventGraph, the order is 2, but it provides its own mapping IDs constructed from the underlyingTemporalGraph. The same will probably be true for an upcomingHigherOrderGraph.