Skip to content

Let the one-rev check pass a lockfile with no git sources #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathscale merged 1 commit into from
Aug 20, 2026
Merged

Let the one-rev check pass a lockfile with no git sources #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/check-one-rev-per-git-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ set -euo pipefail
lock="${1:-Cargo.lock}"

# `source = "git+URL?rev=SHA#SHORTSHA"` - strip the fragment, split on `?rev=`.
#
# `|| true` on the grep because a lockfile with no git sources at all is the
# goal, not a failure, and grep exits 1 when it matches nothing. Under
# `pipefail` that failed the check on precisely the lockfile it most wants to
# see, which is what happened the day the last git dependency went away.
duplicates=$(
grep -o 'source = "git+[^"]*"' "$lock" |
{ grep -o 'source = "git+[^"]*"' "$lock" || true; } |
sed 's/source = "git+//; s/"$//; s/#.*//' |
sort -u |
awk -F'\\?rev=' 'NF == 2 { count[$1]++; revs[$1] = revs[$1] "\n " $2 }
Expand All @@ -46,4 +51,8 @@ if [[ -n $duplicates ]]; then
exit 1
fi

echo "one rev per git source"
if grep -q 'source = "git+' "$lock"; then
echo "one rev per git source"
else
echo "no git sources"
fi
Loading