test: recover two stranded rendering tests - #82
Closed
pathscale wants to merge 1 commit into
Closed
Conversation
Three consecutive builds of a consuming app shipped a completely opaque window while every test it had stayed green. Those tests read the stylesheet source and the JavaScript that writes the alpha; neither looks at a pixel, so neither could tell a working chain from a broken one, and a screenshot was the only feedback available. `window_alpha_admits_light` renders the declaration that app actually ships and asserts the backdrop comes through at low alpha, is hidden at full alpha, and moves continuously between them. `supports_gated_color_mix` settles a suspicion rather than a bug. Lightning CSS emits `color-mix` as progressive enhancement, keeping an opaque fallback outside `@supports (color: color-mix(in lab, red, red))` and the real value inside it, and in one bundle 205 of 501 uses are wrapped that way. If the query did not match, every one of them would silently render at its fallback. It does match, for gated rules and for gated custom properties, and `color-mix` with `transparent` produces alpha correctly. Worth having as a one second answer, because "the engine is quietly taking fallbacks" is expensive to re-litigate from scratch.
Owner
Author
|
Superseded by #83, which stacks all three into one PR with the 0.4.1 workspace bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Two test files that were written on a local branch on 2026-08-19 and never landed. They do not exist on master:
tests/blitz-tests/tests/window_alpha_admits_light.rs— proves a translucent surface admits what is behind ittests/blitz-tests/tests/supports_gated_color_mix.rs— proves an@supports-gated rule wins over its fallback215 lines, additive only. No source changes.
Verified
Cherry-picked cleanly onto current master (
ff31bb55) and run there: 6 tests, 0 failures.Why this is the whole recovery
I swept every local branch across ps-blitz, agencyzero, tauri-runtime-blitz, ps-observability, ps-boa and chuzz looking for stranded development — around 40 local-only branches. Almost all of it is already merged, and it took three wrong methods to establish that:
git cherry(patch-id)The five that
git cherryflagged and master already has, in evolved form:fetch_response_async— present inblitz-netblitz-wasm/src/events.rsandcounters.rs— presentblitz-shell/src/window.rsSetFocusaction indioxus-native-domagencyzero's
fix/color-wheel-first-paintlooked like the largest find of all (40 commits, 114 files). Every commit is patch-equivalent to master. Same for every tauri-runtime-blitz and ps-observability branch.So the honest result of the sweep is that there was no backlog — just these two tests.