This repository was archived by the owner on Aug 3, 2026. It is now read-only.
Revalidate unique-index point reads - #185
Closed
pathscale wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by #187, which consolidated and merged the backend-selection and publication hardening work after the combined review and validation rounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderedFloatequality semantics for floating-point unique indexesCorrectness boundary
A stale unique-index entry can no longer make
select_by_<unique>return a row whose indexed field differs from the requested key. A mismatch returnsNone. This change does not claim that the lookup is linearizable or retry a concurrently changing index.Verification
cargo test --workspace --all-targets: passed (486 passed, 5 ignored across the main suites, plus workspace crate tests)cargo fmt --all -- --check: passedcargo clippy --all-targets -- -D warnings: passedcargo clippy --workspace --all-targets -- -D warnings: reaches a pre-existingclippy::useless_conversionfailure inperformance_measurement/codegen/src/performance_measurement.rs:90Performance
Criterion
unique_index_select_by_test, seven alternating before/after pairs (30 samples, 0.5 s warm-up, 1 s measurement):No measurable regression was found, so this correctness check is not feature-gated.