Feat/improvements - #6
Merged
Merged
Conversation
* Implement a new availability check before domain registration to ensure the domain is purchasable. * Introduce unit tests for the availability check functionality, validating both available and unavailable domain scenarios. * Refactor the registration command to handle availability responses and return appropriate error messages for unavailable domains.
* Update the URL for domain details in the runOpen function to reflect the correct endpoint. * Ensure consistency in URL structure for better clarity and functionality.
* Enhance the availability check process in the registration command to include a loading spinner for better user feedback. * Update error handling to provide clearer messages for unavailable domains, including reasons for unavailability. * Revise unit tests to improve assertions and clarify expected outcomes during the availability check, ensuring accurate validation of both available and unavailable scenarios.
* Introduce Homebrew tap configuration for the namecom CLI, including metadata such as homepage, description, and installation instructions. * Update GitHub Actions workflow to include the HOMEBREW_TAP_GITHUB_TOKEN environment variable for secure access during releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.