Enhance domain registration and availability checks - #8
Merged
Conversation
- Update comments in `manage_test.go` for clarity on endpoint behavior. - Add a new test `TestRegister_DryRunSkipsAvailabilityCheck` to ensure dry-run mode skips availability checks and domain creation. - Modify `runRegister` in `register_renew.go` to clarify the use of CheckAvailability for authoritative checks. - Introduce an `--authoritative` flag in `search_check.go` to allow direct registry checks, bypassing DNS zone checks for improved accuracy. - Refactor availability checking logic to handle unsupported TLDs and improve parallel pricing fetching for available domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manage_test.gofor clarity on endpoint behavior.TestRegister_DryRunSkipsAvailabilityCheckto ensure dry-run mode skips availability checks and domain creation.runRegisterinregister_renew.goto clarify the use of CheckAvailability for authoritative checks.--authoritativeflag insearch_check.goto allow direct registry checks, bypassing DNS zone checks for improved accuracy.