Feat/fix bugs - #9
Merged
Merged
Conversation
- Add a new `contentTypeServer` function in `manage_test.go` to validate the Content-Type header for JSON responses. - Introduce `cmdForToggle` to facilitate testing of toggle commands with a persistent `--yes` flag. - Create `TestContentTypeHeader_AllToggleCommands` to ensure all toggle commands correctly assert the Content-Type header. - Update `runLock`, `runAutorenew`, and `runPrivacy` functions in `manage.go` to include Content-Type parameters for API requests, ensuring consistent handling of JSON content type.
- Implement sequential pagination handling in `runList` to retrieve all domains when the last page is unknown. - Update hint message in `runRegister` to correct the command syntax for enabling auto-renewal, improving user guidance. - Add logic to handle unsupported domains in `runCheck`, ensuring accurate reporting of domain availability and enhancing user experience.
- Enhance DNS validation tests by adding cases for overly long labels and total character limits. - Introduce a new test for sequential pagination handling when the last page is omitted, ensuring all domains are retrieved correctly. - Implement tests for rendering search results in various formats, including handling empty results and quiet mode output, improving overall test coverage and reliability.
- Introduce tests for DNS listing to verify behavior when more records are available, ensuring the "More records" hint is displayed correctly. - Implement tests for handling empty records and type filtering in DNS listings, enhancing overall test coverage. - Refactor the `fetchAllRecords` function to improve pagination handling and ensure accurate retrieval of all records across multiple pages.
- Introduce tests for DNS update functionality to ensure type changes are validated against existing answers, preventing invalid updates. - Implement domain update tests to verify normalization of domain names during updates, ensuring consistent API interactions. - Enhance the `runUpdate` function to include validation for existing answers when the record type is changed, improving error handling and user feedback.
- Introduce tests for DNS delete functionality to ensure proper error handling for invalid record IDs and domains without dots. - Implement a test for domain normalization during DNS updates, verifying that domain names are correctly formatted in API requests. - Enhance the `runDelete` and `runUpdate` functions to include validation for input parameters, improving error handling and user feedback. - Refactor toggle command functions to validate input values and domain formats, ensuring consistent behavior across commands.
- Introduce tests for the renewal command to validate domain formats and years input, ensuring proper error handling for invalid cases. - Implement tests for the contacts set command to verify domain normalization and file handling, enhancing robustness against bad input. - Refactor command functions to utilize a consistent method for domain argument parsing, improving code clarity and reducing redundancy. - Enhance error messages for better user feedback during command execution, ensuring a smoother user experience.
- Introduce tests for DNSSEC retrieval to validate error handling for domains without dots and ensure correct key retrieval for valid domains. - Implement tests for domain retrieval, including checks for bad domain formats and successful responses, enhancing robustness against invalid input. - Refactor command functions to improve consistency in domain argument parsing and error messaging, ensuring a smoother user experience.
- Introduce tests for contacts retrieval to validate error handling for domains without dots and ensure successful responses for valid domains. - Implement tests for transfer listing and retrieval, including checks for empty responses and successful data retrieval for valid domains. - Add tests for URL listing, retrieval, and updates, ensuring proper error handling for bad domain formats and successful updates. - Enhance vanity command tests to validate error handling for invalid domains and ensure correct entry retrieval, improving overall test coverage and robustness.
- Introduce tests for setting name servers, validating successful requests and error handling for bad domain arguments. - Implement tests for pricing retrieval, ensuring correct handling of valid and invalid domain formats, and verifying output for purchase prices. - Add search functionality tests to check for available domains and handle empty search results, enhancing overall test coverage and robustness.
- Update test server handler functions in `order_test.go`, `url_test.go`, and `validate_test.go` to use underscore for unused request parameters, enhancing code clarity and consistency across test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.