Redesign TX strip (3a) + Band & Mode sheet (3b)

[patrickrb]

Reworks the TX strip to the high-fidelity design (option 3a) and adds the Band & Mode bottom sheet (option 3b) from design_handoff_tx_strip_redesign. Rebased onto current dev and wired into dev's existing Hunt-options feature (this PR does not duplicate it).

TX strip (TxStrip.kt)

• Status row: pulse dot + Listening/Transmitting/Tuning + a live, parity-aware "Next transmit window in Xs" countdown, and the CAT chip.
• 48dp BAND & MODE row ("14.074 MHz · 20m · FT8") opening the new sheet.
• 72dp Call CQ with a visible MORE split-button (replaces the long-press-only affordance; opens the existing CQ-variants menu).
• Hunt tile whose amber chip shows the active hunt priority (or "Off") and opens dev's HuntOptionsSheet; tapping the tile toggles Hunt.
• TX PERIOD segmented control (1st even / 2nd odd) replacing the TX1 toggle.
• Tune / DX buttons; inline volume slider preserved.

Band & Mode sheet (BandModeSheet.kt)

• FT8/FT4/FT2 mode toggle with cycle times (15s / 7.5s / 3.75s).
• Curated most-used band list from assets/bands.txt with plain-English hints (20m is time-of-day aware) and an "All bands & custom frequency" footer → the existing full picker.

Other

• CatStatusChip now reads "Radio linked" / "Radio not linked" (Inter).
• SlotTimerBar gains NextTxWindowLabel + the pure, tested nextTxWindowSeconds; dev's slot bar + clock-sync pill are left in place above the strip.
• Theme tokens + FT8AFIcons reused; all tap targets ≥44dp; px→dp 1:1.

Scope note

An earlier revision of this branch was cut from a stale main and also re-implemented the Hunt priority/smart-filters feature — which already exists on dev. That duplication has been dropped; this PR is now redesign-only and layers on dev's hunt backend.

Tests

Unit tests for the extracted pure logic: nextTxWindowSeconds, txStatusVisuals, formatSlotSeconds, bandHintRes, mostUsedBands, and the CAT chip labels. Full testDebugUnitTest green.

Verification

Built and driven on an emulator against dev: redesigned strip, Band & Mode sheet, TX-period toggle, MORE menu, and the Hunt tile opening dev's Hunt sheet — with dev's clock-sync pill and slot bar intact.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Hunt selection has incorrect edge-case behavior, insufficient engine-level coverage, and several tap targets below the stated minimum.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Redesigns the Compose TX controls and adds configurable Hunt candidate ranking.

Changes:

• Reworks the TX strip, status timer, CAT chip, and band/mode sheet.
• Adds persistent Hunt priorities and smart filters.
• Adds unit tests for extracted UI and ranking logic.

File summaries

File	Description
TxStatusVisualsTest.kt	Tests TX status mapping.
SlotTimerStateTest.kt	Tests slot and next-window timing.
CatStatusChipLogicTest.kt	Tests CAT labels and visuals.
BandModeSheetLogicTest.kt	Tests band/mode helpers.
HuntSelectionTest.kt	Tests Hunt ranking and filtering.
strings_compose.xml	Adds redesigned UI strings.
TxStrip.kt	Implements the redesigned TX controls.
SlotTimerBar.kt	Adds progress and next-window components.
CatStatusChip.kt	Adds plain-language connection labels.
BandModeSheet.kt	Adds band/mode and Hunt sheets.
HuntSelection.kt	Defines Hunt priorities and ranking.
FT8AFApp.kt	Integrates sheets and persisted settings.
GeneralVariables.java	Stores shared Hunt configuration.
FT8TransmitSignal.java	Applies candidate filters and ranking.
DatabaseOpr.java	Loads persisted Hunt settings.

Review details

Suppressed comments (2)

ft8af/app/src/main/kotlin/radio/ks3ckc/ft8af/ui/components/TxStrip.kt:653

• Each TX-period segment is only 36dp high, below the PR's 44dp minimum tap target. The containing card has room for 44dp segments, so expand the clickable boxes.

            .height(36.dp)

ft8af/app/src/main/kotlin/radio/ks3ckc/ft8af/ui/components/BandModeSheet.kt:575

• The minimum-signal chips are only 40dp high, below the stated 44dp minimum tap target. Increase the clickable height to at least 44dp.

            .height(40.dp)

• Files reviewed: 15/15 changed files
• Comments generated: 8
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 9.87203% with 493 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.41%. Comparing base (c481a35) to head (186b6ae).

Files with missing lines	Patch %	Lines
...kotlin/radio/ks3ckc/ft8af/ui/components/TxStrip.kt	2.45%	278 Missing ⚠️
.../radio/ks3ckc/ft8af/ui/components/BandModeSheet.kt	19.54%	139 Missing and 1 partial ⚠️
...app/src/main/kotlin/radio/ks3ckc/ft8af/FT8AFApp.kt	0.00%	52 Missing ⚠️
...n/radio/ks3ckc/ft8af/ui/components/SlotTimerBar.kt	33.33%	16 Missing ⚠️
.../radio/ks3ckc/ft8af/ui/components/CatStatusChip.kt	41.66%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev     #762      +/-   ##
============================================
- Coverage     41.58%   41.41%   -0.18%     
  Complexity      290      290              
============================================
  Files           282      283       +1     
  Lines         33350    33624     +274     
  Branches       4017     4055      +38     
============================================
+ Hits          13870    13924      +54     
- Misses        19124    19343     +219     
- Partials        356      357       +1     

Flag	Coverage Δ
android	17.90% <9.87%> (+0.02%)	⬆️
native	9.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../radio/ks3ckc/ft8af/ui/components/CatStatusChip.kt	40.90% <41.66%> (+5.42%)	⬆️
...n/radio/ks3ckc/ft8af/ui/components/SlotTimerBar.kt	25.00% <33.33%> (+3.57%)	⬆️
...app/src/main/kotlin/radio/ks3ckc/ft8af/FT8AFApp.kt	0.42% <0.00%> (-0.03%)	⬇️
.../radio/ks3ckc/ft8af/ui/components/BandModeSheet.kt	19.54% <19.54%> (ø)
...kotlin/radio/ks3ckc/ft8af/ui/components/TxStrip.kt	5.47% <2.45%> (+1.06%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟡 Changes recommended

Dial selection can be displayed incorrectly, and several redesigned controls remain inaccessible or unusable on constrained displays.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

ft8af/app/src/main/kotlin/radio/ks3ckc/ft8af/ui/components/BandModeSheet.kt:311

• The checkmark and highlight are visual only, so TalkBack cannot tell which dial is currently selected. Give each row selectable/radio-button semantics with selected = selected rather than a plain clickable.

            .clickable { onClick() }

ft8af/app/src/main/kotlin/radio/ks3ckc/ft8af/ui/components/TxStrip.kt:694

• active only changes colors, so TalkBack cannot announce whether the Tune/DX toggle is on or off (especially DX, whose label never changes). Use toggleable semantics or expose a localized state description tied to active.

            .clickable(enabled = enabled) { onClick() }

• Files reviewed: 10/10 changed files
• Comments generated: 6
• Review effort level: Balanced