Align iOS capture methods and SourceBraid rebrand - #3
Merged
Conversation
Signed-off-by: Patrick Schiller <p@trickschiller.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dom-readableand the specializedgoogle-deepmind-dommethodpdf-docling-pending,source.pdf, conversion metadata, and a metadata-first/PDF-last upload orderde.patrickschiller.stowmarkbundle IDs, App Group, and Keychain identifiers so TestFlight upgrades preserve configuration and credentialsWhy
The iOS client still emitted older generic capture-method values and uploaded PDF attachments before their Markdown/index metadata. That did not match the current archive format or the PDF workflow trigger contract. The SourceBraid rebrand also needs to update the visible product name without turning the existing TestFlight app into a separate application or losing shared settings.
User and developer impact
No new iOS permissions, GitHub scopes, network endpoints, or credential logging are introduced. The storage-format additions use fields already understood by the existing PDF conversion workflow.
Validation
/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -quiet -project SourceBraid.xcodeproj -scheme SourceBraid -destination 'platform=iOS Simulator,id=9FEEB5A9-425E-4369-BBCE-C13841AA9FEF' -derivedDataPath /tmp/sourcebraid-public-pr-derived test— 4 tests passednode --test tests/capture-utils.test.js— 15 tests passedpython3 -m unittest discover -s tests -p 'test_*.py'— 27 tests passedPublic-release safety
The commit contains only an explicit allowlist of 13 files under
ios/. It contains nowebsite/,web-clips/, credentials, indexes, build artifacts, or private repository history.