Skip to content

feat(web): collapsible Settled shelf when hide settled on classic Recent - #139

Merged
patroza merged 2 commits into
fork/changesfrom
feat/sidebar-v1-settled-shelf-when-hidden
Jul 28, 2026
Merged

feat(web): collapsible Settled shelf when hide settled on classic Recent#139
patroza merged 2 commits into
fork/changesfrom
feat/sidebar-v1-settled-shelf-when-hidden

Conversation

@patroza

@patroza patroza commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Classic Sidebar Recent (recency / none): with Hide settled on, settled threads no longer disappear. They sit in a collapsible Settled shelf at the bottom of the list, same idea as Sidebar V2.
  • Active (non-settled) threads stay in the main list with existing recency headers.
  • Shelf matches V2 affordances: expand/collapse (shared expanded preference), count when collapsed, open route row stays visible when collapsed, paged “Show more”, sorted by settle/end time.
  • Project grouping is unchanged (hide still omits settled from each project’s list).
  • Jump shortcuts use the main inbox only while settled are shelved.

Test plan

  • Classic Threads, grouping Recency or None, Hide settled on (default): main list has non-settled only; Settled shelf at bottom with settled threads
  • Toggle shelf collapsed/expanded; collapsed shows count; open settled thread still appears when collapsed
  • Hide settled off: settled interleave in the main list again (no shelf)
  • Many settled: initial page + Show more
  • Project grouping: hide settled still filters project thread lists (no shelf change)
  • A/B with V2: shelf expand preference is shared

@patroza
patroza force-pushed the feat/sidebar-v1-settled-shelf-when-hidden branch from 9182dd2 to 212cca4 Compare July 28, 2026 10:11
Classic v1 recency/none no longer drops settled threads when Hide settled is
on. Active threads stay in the main list; settled move to a bottom shelf
(collapsible, paged, keep open route row) matching Sidebar V2.
@patroza
patroza force-pushed the feat/sidebar-v1-settled-shelf-when-hidden branch from 212cca4 to d25a0be Compare July 28, 2026 10:11
Unblocks package typecheck after ElectronApp gained onBeforeQuitForUpdate;
other desktop test mocks already stubbed it.
@patroza
patroza merged commit 0fd0d44 into fork/changes Jul 28, 2026
10 checks passed
patroza added a commit that referenced this pull request Jul 29, 2026
…ent (#139)

* feat(web): collapsible Settled shelf when hide settled on classic Recent

Classic v1 recency/none no longer drops settled threads when Hide settled is
on. Active threads stay in the main list; settled move to a bottom shelf
(collapsible, paged, keep open route row) matching Sidebar V2.

* fix(desktop): stub onBeforeQuitForUpdate in DesktopUpdates tests

Unblocks package typecheck after ElectronApp gained onBeforeQuitForUpdate;
other desktop test mocks already stubbed it.

---------

Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Jul 29, 2026
…ent (#139)

* feat(web): collapsible Settled shelf when hide settled on classic Recent

Classic v1 recency/none no longer drops settled threads when Hide settled is
on. Active threads stay in the main list; settled move to a bottom shelf
(collapsible, paged, keep open route row) matching Sidebar V2.

* fix(desktop): stub onBeforeQuitForUpdate in DesktopUpdates tests

Unblocks package typecheck after ElectronApp gained onBeforeQuitForUpdate;
other desktop test mocks already stubbed it.

---------

Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Jul 29, 2026
…ent (#139)

* feat(web): collapsible Settled shelf when hide settled on classic Recent

Classic v1 recency/none no longer drops settled threads when Hide settled is
on. Active threads stay in the main list; settled move to a bottom shelf
(collapsible, paged, keep open route row) matching Sidebar V2.

* fix(desktop): stub onBeforeQuitForUpdate in DesktopUpdates tests

Unblocks package typecheck after ElectronApp gained onBeforeQuitForUpdate;
other desktop test mocks already stubbed it.

---------

Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant