ci(fork): move to a new concurrency generation - #369
Merged
Conversation
Last night's push run for 15a0c5d is wedged. GitHub refuses to cancel it -- "Cannot cancel a workflow re-run that has not yet queued", a state my own re-run request put it in -- so it holds its concurrency group indefinitely and the current fork/dev tip 009b3f9 never got a run at all. Prefix the group with a generation, ci-v2-. New runs land in a fresh namespace and cannot queue behind anything wedged under the old key. Nothing depends on the literal value; bump it again if this recurs. The per-SHA keying and the no-cancel-on-push rule are unchanged: a push run's conclusion is what approves that commit for deployment, so cancelling one as superseded would leave that SHA unapprovable. Also remove .macroscope, which configured the Effect Service Conventions check run agent. That disables the custom agent only. Macroscope's built-in checks come from the installed GitHub App, so the app has to be uninstalled from the repository to stop them; it had already been reporting "Skipped -- billing issue" on pull requests. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Restores .macroscope/ removed one commit earlier; the check-run agent stays. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
omegent-app
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrency: new generation
Last night's push run for
15a0c5d59is wedged. GitHub refuses to cancel it:That state came from my own re-run request while diagnosing the runner outage — worth owning,
since it is what turned a stalled run into an uncancellable one. It holds its concurrency group
indefinitely, and the current
fork/devtip009b3f9c6has no run at all as a result.Prefixing the group with a generation —
ci-v2-— puts new runs in a fresh namespace where nothingcan queue behind the wedged run. Nothing depends on the literal value; bump it again if this recurs.
Unchanged: per-SHA keying and no-cancel-on-push. A push run's conclusion is what approves that commit
for deployment, so cancelling one as superseded would leave that SHA unapprovable.
Macroscope
Withdrawn: the config stays.
.macroscope/was removed in the first commit and restored in thesecond, per review — the branch nets to no Macroscope change.
After this merges
009b3f9c6still has no run, and the poller only promotes a SHA with a successfulfork-cipushrun — so the fleet stays where it is until a push lands under the new key. Merging this is itself
such a push, which should produce the first
ci-v2-run and unblock the queue.Co-authored by @patroza
opened by Patrick Roza in chat thread Discord · Discord · T3