ci: point the adopted web-preview workflow at the fork's runners - #386
Merged
Conversation
Upstream's pingdotgg#5465 runs on blacksmith-8vcpu-ubuntu-2404. Every fork workflow uses GitHub-hosted runners, so the job would queue forever if anyone applied the preview:web label. It also needs VERCEL_* secrets the fork does not set, so the workflow stays dormant either way — this just removes the footgun. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
omegent-app Bot
added a commit
that referenced
this pull request
Aug 10, 2026
pingdotgg#5609 also added mobile-fingerprint-check.yml, which landed without a conflict and so was never inspected. It runs on blacksmith-8vcpu-ubuntu-2404, which this fork does not have, and it triggers on every pull request touching apps/mobile, packages/client-runtime, packages/contracts, packages/shared, assets or scripts. Its "Native fingerprint diff" check was already sitting queued on this very PR and would never have reported — a permanently pending check, and a blocked merge wherever branch protection waits on all of them. Same fix as #386 for web-preview.yml: GitHub-hosted runners, which is what every other fork workflow uses. There are now no Blacksmith references left in .github/workflows. Also drops the EllipsisIcon import the Sidebar conflict union left behind; the project row's button is SettingsIcon after pingdotgg#5923. Found by the grok-4.5 adversarial review. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #385. This one-line change was pushed to the sync branch after #385 had already
been merged at
841252ce6, so it never reachedfork/dev.Upstream's pingdotgg#5465 runs the new hosted-web preview job on
blacksmith-8vcpu-ubuntu-2404. Every forkworkflow uses GitHub-hosted runners (
ci.ymlisubuntu-24.04/macos-15throughout), andweb-preview.ymlwas the only Blacksmith reference in the tree — so the job would queue forever ifanyone ever applied the
preview:weblabel.The workflow is label-gated and also needs
VERCEL_TOKEN/VERCEL_ORG_ID/VERCEL_PROJECT_ID,which the fork does not set, so it stays dormant either way. This just removes the footgun rather
than leaving a job that cannot be scheduled.
Found by the grok-4.5 adversarial review of #385.
Co-authored by @patroza
opened by Patrick Roza in chat thread Discord · Discord · T3