Bootstrap Treeview V2#437
Conversation
| "eonasdan-bootstrap-datetimepicker": "~4.17.37", | ||
| "moment": "~2.14.1", | ||
| "patternfly-bootstrap-treeview": "~1.0.0" | ||
| "patternfly-bootstrap-treeview": "patternfly" |
There was a problem hiding this comment.
Will update this PR with 2.0.0 after it is published and #1 is merged.
priley86
force-pushed
the
treeview-testing
branch
from
ed7688d to
d441ced
Compare
| padding: 0 10px; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
|
|
priley86
force-pushed
the
treeview-testing
branch
from
d441ced to
f02ccee
Compare
| margin-right: 5px; | ||
| } | ||
| .node-disabled { | ||
| color:silver; |
There was a problem hiding this comment.
This should use a color from the patternfly palette.
There was a problem hiding this comment.
@jeff-phillips-18 thanks - I will update it shortly.
priley86
force-pushed
the
treeview-testing
branch
from
f02ccee to
b5d351f
Compare
|
@jeff-phillips-18 I've updated the PR to reflect these changes. Thanks for the review! I will update this PR once more after #1 is merged/published. |
priley86
force-pushed
the
treeview-testing
branch
from
b5d351f to
a8cf8a4
Compare
| @color-pf-red: @color-pf-red-100; | ||
| @color-pf-white: #fff; No newline at end of file | ||
| @color-pf-white: #fff; | ||
| @color-pf-silver: #c0c0c0; No newline at end of file |
There was a problem hiding this comment.
Is there an existing color we could use? Adding a color to the color palette means updating a bunch of other places. @kybaker do you have any suggestions?
There was a problem hiding this comment.
Silver sounds fantastic, but it'd be more accurate if we use one of our -blacks.
If no black match the color we are looking for then create a new black-xxx. looping @kybaker
|
@priley86 The color you specified works. We need to make a note to define this in PatternFly in the future. |
|
@color-pf-silver: #c0c0c0; seems very close to either: Is it worth defining a new color variable? |
|
@jeff-phillips-18 @priley86 We should avoid creating any new variables we have plenty of values to choose for this, please go with @color-pf-black-300: #d1d1d1; |
priley86
force-pushed
the
treeview-testing
branch
2 times, most recently
from
49ed86b to
82bba62
Compare
|
@jeff-phillips-18 @dlabrecq @bleathem i've updated this PR after publishing the V2 changes in our fork. Please give this one more look! |
| black700: '#4d5258', | ||
| black800: '#393f44', | ||
| black900: '#292e34', | ||
| black950: '#363636', |
There was a problem hiding this comment.
Do we need to add this? Why not just use the existing black900?
There was a problem hiding this comment.
@jeff-phillips-18 I'm ok with this...just noticed nothing had been added to exactly match the body color #363636. updating...
|
This PR build and runs as expected. I see the changes on the treeview pages that we expect. The code changes seem reasonable to me. 👍 |
* incorporates V2 of treeview * adds checkboxes and hierarchal checks tests * adds highlight select and new highlight styles * adds lazy load test * adds prevent unselect test * adds disabled nodes test * ensure list-group-item overflow is handled
priley86
force-pushed
the
treeview-testing
branch
from
82bba62 to
97df15d
Compare
|
LGTM |
5 participants
Description
Upgrade Patternfly to Bootstrap Treeview V2
Changes: