V2 changes to bootstrap-treeview by priley86 · Pull Request #1 · patternfly/patternfly-bootstrap-treeview

priley86 · 2016-07-21T21:36:39Z

Adds commits currently in the bootstrap-treeview develop branch
Adds #266, #263, and #262
Adds changes to span.image styling to resemble span.font styling and .gitignore changes. 47d9b72
Adds hierarchical checking of checkboxes b26e546
Adds fix for jquery 3, bc19d2c

priley86 · 2016-07-21T21:56:24Z

@bleathem @andresgalante @skateman @dlabrecq

I've attempted to capture all patternfly desired changes to bootstrap-treeview in this PR in our new fork. Since this project is no longer actively maintained, a new fork is needed.

Please let me know what you guys think.

dlabrecq · 2016-07-21T23:33:52Z

Is this a POC? Looking through Gitter and obviously missed some conversation, so please fill me in.

Are you suggesting that the delevop branch is no longer maintained, too?

I recall Leslie was going to identify required features for a new component. (We should include her in this review.) Does this have all the features Patternfly is looking for?

skateman · 2016-07-22T07:07:33Z

These features are filed as PR against the upstream repo ...

priley86 · 2016-07-22T12:04:43Z

@skateman @dlabrecq we are discussing the option of sourcing this fork in patternfly for the time being. The upstream maintainer has not been responsive and it seems we have a lot of contributions we'd like added very soon.

There will be more discussion on this before it's merged to Patternfly :)

priley86 · 2016-07-26T14:49:56Z

@bleathem @dlabrecq @skateman any other editions we'd like added now to this?

Once this is merged, we can add a new npm/bower module for this, "patternfly-bootstrap-treeview". We can always release and append new changes in our new fork later, in a timely manner :)

Afterwards, I will add a new PR to reference this in Patternfly.

skateman · 2016-07-26T14:59:22Z

LGTM 👍

priley86 · 2016-08-05T15:10:19Z

@dlabrecq @skateman i've added a jquery v3 fix (we can use JSON.parse instead of now deprecated jQuery.parseJSON). I think this PR is ready for merge so we can adopt patternfly-bootstrap-treeview v2 (changes here) next release in Patternfly . I will follow up with another PR in Patternfly with changes noted here

priley86 · 2016-08-05T15:11:53Z

@skateman can you add a PR in the now forked upstream ?

dlabrecq · 2016-08-09T13:52:08Z

LGTM. Although, I'm leary of merging with Brian and Andres on PTO. Don't want to be put on trial, again.

priley86 · 2016-08-09T14:16:26Z

@dlabrecq should be fine to hold off on this until @bleathem & @andresgalante review. We are still awaiting icons/design on the checkmarks anyhow. @skateman requested this be released sometime this month for mIQ, so will shoot for the following release (Aug. 30).

- Split render method, with renderNode added to render an individual node - Resolved test issues with expand collapse functions

- The class node-selected is added via setSelectedState - Removed inline style that sets color + background-color based on selected state - Updated injected css to use options selectedColor + selectedBackColor - Allows of user override via .css resource

…tion. #76

…ay of nodes.

Resolves #223

(cherry picked from commit 1171b3f)

(cherry picked from commit aaaa6da)

(cherry picked from commit 634b5e5)

(cherry picked from commit 4f8e18e)

(cherry picked from commit e0b8db9)

(cherry picked from commit 8552a1b)

(cherry picked from commit 66181e3)

If enabled, the disabled node will keep its expanded/checked/selected state. (cherry picked from commit d4ef058)

(cherry picked from commit 1ca45b1)

By setting `highlightChanges` to true, the changed checkboxes will have `changedNodeColor`. The default checkbox state can be reset by calling the `unmarkCheckboxChanges()` function. (cherry picked from commit 798f7e8)

(cherry picked from commit 5cc82ee)

(cherry picked from commit 6550b42)

priley86 · 2016-08-26T14:21:28Z

@dlabrecq @skateman @bleathem please check once more when you get a chance. I think we are ready.

skateman · 2016-08-26T17:37:42Z

LGTM 👍

andresgalante · 2016-08-29T12:07:52Z

@priley86 I really don't know what I should review 😄 sorry. If @skateman @dlabrecq and/or @bleathem are ok with it, then 🚀 !

priley86 · 2016-08-29T14:59:27Z

@andresgalante we are just reviewing @skateman's V2 changes before we incorporate in our fork. Would like to merge this one first, and then update #437 to reference V2 after it's published.

dlabrecq · 2016-08-29T20:30:35Z

Not certain what's changed since I last reviewed, but looks ok? I'll defer to @bleathem .

priley86 · 2016-08-30T18:34:03Z

@bleathem i think this is ready for merge. can you do the honors?

bleathem · 2016-08-30T18:54:50Z

This PR has been reviewed for functional and visual correctness using the patternfly test pages by both designers and developers and deemed to be acceptable. A scan of the code changes looks reasonable, and I'm happy to see the supporting documentation changes.

I'd say this PR is ready to merge.

priley86 force-pushed the patternfly branch 2 times, most recently from c6aab84 to 3b9ebcb Compare July 21, 2016 21:50

priley86 force-pushed the patternfly branch from 3b9ebcb to bcc4431 Compare July 22, 2016 11:57

priley86 force-pushed the patternfly branch from bcc4431 to 9f2571c Compare July 25, 2016 17:50

priley86 mentioned this pull request Jul 26, 2016

Update bower/npm for new dependency #2

Merged

priley86 force-pushed the patternfly branch 3 times, most recently from 46c6458 to d2bb044 Compare August 1, 2016 15:44

priley86 force-pushed the patternfly branch 2 times, most recently from 75ffda2 to 58b84f9 Compare August 16, 2016 15:33

priley86 force-pushed the patternfly branch 2 times, most recently from f594ffd to 8de91f2 Compare August 24, 2016 20:10

priley86 changed the title ~~Patternfly changes to bootstrap-treeview~~ V2 Patternfly changes to bootstrap-treeview Aug 25, 2016

priley86 changed the title ~~V2 Patternfly changes to bootstrap-treeview~~ V2 changes to bootstrap-treeview Aug 25, 2016

priley86 mentioned this pull request Aug 25, 2016

Bootstrap Treeview V2 patternfly/patternfly-3#437

Merged

jonmiles added 5 commits August 26, 2016 10:17

Work on render changes, work in progress #76

989bf06

- Split render method, with renderNode added to render an individual node - Resolved test issues with expand collapse functions

Removed necessary option extension, already handled in forEachIdentifier

aeb8d76

Node checked update to render checked/unchecked state via css only. #76

18470f7

Node disabled update to render state change with minimal DOM manipula…

92ed881

…tion. #76

jonmiles and others added 21 commits August 26, 2016 10:17

Implemented addNodes

46aba1e

Implemented addNodeAfter, addNodeBefore

5c4bd1a

Implemented removeNode, updateNode

9931498

Ensure all API methods accept nodes as either a single node or an arr…

58c86d2

…ay of nodes.

Documented additional method; getNodes

afa8afe

Tidy

32e31ba

Update package dependencies

e76565d

Resolves #223

Remove bower from build process / dependencies

7f3dee4

Add custom data- and #id/.class attributes per node

0641060

(cherry picked from commit 1171b3f)

Add the option to hide checkboxes on a node-level

6a8cca4

(cherry picked from commit aaaa6da)

Add the option for swapping the order of node/checkbox icons

fb499d5

(cherry picked from commit 634b5e5)

Add per-node option for displaying an image instead of an icon

5daf134

(cherry picked from commit 4f8e18e)

Implement hierarchical checking of checkboxes

be7a49d

(cherry picked from commit e0b8db9)

Implemented lazy-loading support when expanding a tree node

e838cb1

(cherry picked from commit 8552a1b)

Use JSON.parse instead of $.parseJSON for jQuery v3 compatibility

178d50b

(cherry picked from commit 66181e3)

Add the keepState parameter when disabling node(s)

e73f0df

If enabled, the disabled node will keep its expanded/checked/selected state. (cherry picked from commit d4ef058)

Implemented non-checkable node similarly to non-selectable

4386d15

(cherry picked from commit 1ca45b1)

Implement feature for highlighting nodes with changed checkboxes

de58f3f

By setting `highlightChanges` to true, the changed checkboxes will have `changedNodeColor`. The default checkbox state can be reset by calling the `unmarkCheckboxChanges()` function. (cherry picked from commit 798f7e8)

Add a parameter to optionally wrap the thext with a <span> tag

87bbde9

(cherry picked from commit 5cc82ee)

Added optional per-node tooltip attribute

04f6173

(cherry picked from commit 6550b42)

Run grunt

67f86db

priley86 force-pushed the patternfly branch from 8de91f2 to 67f86db Compare August 26, 2016 14:20

bleathem merged commit bcf605e into master Aug 30, 2016

Conversation

priley86 commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priley86 commented Jul 21, 2016

Uh oh!

dlabrecq commented Jul 21, 2016

Uh oh!

skateman commented Jul 22, 2016

Uh oh!

priley86 commented Jul 22, 2016

Uh oh!

priley86 commented Jul 26, 2016

Uh oh!

skateman commented Jul 26, 2016

Uh oh!

priley86 commented Aug 5, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priley86 commented Aug 5, 2016

Uh oh!

dlabrecq commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priley86 commented Aug 9, 2016

Uh oh!

priley86 commented Aug 26, 2016

Uh oh!

skateman commented Aug 26, 2016

Uh oh!

andresgalante commented Aug 29, 2016

Uh oh!

priley86 commented Aug 29, 2016

Uh oh!

dlabrecq commented Aug 29, 2016

Uh oh!

priley86 commented Aug 30, 2016

Uh oh!

bleathem commented Aug 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

priley86 commented Jul 21, 2016 •

edited

Loading

priley86 commented Aug 5, 2016 •

edited

Loading

dlabrecq commented Aug 9, 2016 •

edited

Loading