docs: add clarity on how to use bullseye layout #1136
Merged
starryeyez024 merged 6 commits intomasterfrom Oct 15, 2020
Merged
Conversation
Contributor
|
To center an item inside a container, I think it makes sense to make it 100% or flex-grow: 1 if that container is set to flex too. |
castastrophe
added
size: sm
castastrophe
changed the title
…y-elements into fix-bullseye-layout * 'fix-bullseye-layout' of github.com:patternfly/patternfly-elements: chore(deps-dev): bump husky from 1.3.1 to 4.3.0 (#1131) chore(deps-dev): [security] bump lodash from 4.17.15 to 4.17.20 (#1128) chore(deps-dev): bump @wdio/mocha-framework from 6.4.0 to 6.5.0 (#1129) chore(deps-dev): bump @storybook/addon-viewport from 5.3.8 to 6.0.26 (#1132) chore: Update automerge logic (#1133) feat: Migrate tests to GitHub Actions (#1119)
starryeyez024
changed the title
castastrophe
reviewed
Oct 8, 2020
castastrophe
changed the title
markcaron
approved these changes
Oct 15, 2020
Contributor
markcaron
left a comment
markcaron
left a comment
There was a problem hiding this comment.
Los Guapos Tomamos Mezcal
Contributor
|
I did. The bullseye seemed to work fine on Edge, 11, FF, Chrome and Safari. I don't see a checklist either, am I missing any browsers you all check specifically beyond "the big 5"? |
Member
Author
|
Since no code changed in this PR (docs only) it was exempt from browser testing, so I removed the normal list of browsers. |
Contributor
|
Yeah I saw that, that's why I deleted the comment. I was out-of-date with the direction the PR took. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component name
Preview
What has changed and why
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!