Skip to content

feat: added vars to control padding on host and margin on icon #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castastrophe merged 3 commits into from
Jan 22, 2021
Merged

feat: added vars to control padding on host and margin on icon #1290

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30b3fc2
feat: added vars to control padding on host and margin on icon
heyMP Jan 22, 2021
536affd
Branch was auto-updated with the latest.
github-actions[bot] Jan 22, 2021
eeeeb78
Branch was auto-updated with the latest.
github-actions[bot] Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions elements/pfe-clipboard/src/pfe-clipboard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ $LOCAL: clipboard;
// This variable is global so that helper functions can reference it
$LOCAL-VARIABLES: (
FontSize: 1rem,
Padding: 6px 16px,
FontWeight: pfe-var(font-weight--light),
Color: pfe-broadcasted(link),
Color--hover: pfe-broadcasted(link--hover),
Color--focus: pfe-broadcasted(link--focus),
text--success--Color: pfe-var(feedback--success),
icon--Width: pfe-var(icon-size),
icon--Height: auto,
icon--Margin: 0 0.4825rem 0 0, // 7.72px
);

:host {
Expand All @@ -23,8 +25,7 @@ $LOCAL-VARIABLES: (
color: pfe-local(Color) !important;
font-weight: pfe-local(FontWeight);
cursor: pointer;
// @todo: How should we handle padding with inline elements?
padding: 6px 16px;
padding: pfe-local(Padding);
}

:host([hidden]) {
Expand All @@ -38,7 +39,7 @@ $LOCAL-VARIABLES: (
width: pfe-local(icon--Width);
// This is needed if the icon isn't square
height: pfe-local(icon--Height);
margin-right: 0.4825rem; // 7.72px
margin: pfe-local(icon--Margin);
}
&__text {
font-size: pfe-local(FontSize) !important;
Expand Down