Skip to content

Conversation

@castastrophe
Copy link
Contributor

After the typography update, the baselines needed to be updated.

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe castastrophe added tools Development and build tools ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! priority: low Severity level: 3 labels Feb 9, 2021
@castastrophe castastrophe added run e2e Trigger automated visual regression tests and removed ready: branch testing Test the component from a user-perspective. Try to break it! tools Development and build tools labels Feb 9, 2021
@starryeyez024
Copy link
Member

The pfe-primary-detail component does not have any of the typographical styles, but it does include pfe-base.css. When I view it locally, it looks good:
image

@castastrophe castastrophe merged commit 76405e1 into master Feb 11, 2021
@castastrophe castastrophe deleted the chore-update-baselines-files branch February 11, 2021 02:07
starryeyez024 added a commit that referenced this pull request Feb 11, 2021
…patternfly-elements into typography--font-weight-swap

* 'typography--font-weight-swap' of github.com:patternfly/patternfly-elements:
  chore(deps-dev): bump @storybook/addon-viewport from 6.1.16 to 6.1.17 (#1329)
  chore(deps-dev): bump @storybook/addon-actions from 6.1.16 to 6.1.17 (#1333)
  chore: update baselines files from typography update (#1340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Severity level: 3 ready: code review Ready for code review! run e2e Trigger automated visual regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants