chore: Watch needs to be run in parallel #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhawkins
reviewed
Mar 17, 2021
| }`; | ||
|
|
||
| module.exports.lernaRun = (command, components) => `lerna -- run ${command} --no-bail --stream --include-dependencies ${ | ||
| module.exports.lernaRun = (command, components) => `lerna -- run ${command} --no-bail ${command === "build" ? `--stream` : `--parallel`} --include-dependencies ${ |
Contributor
There was a problem hiding this comment.
Looks fine but this command is getting mighty long. May be worth pulling this ternary out to it's own line.
Contributor
Author
There was a problem hiding this comment.
+1 Mind if we tackle that in another issue?
zhawkins
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In removing the parallel runs, I neglected to update the command to run the watch in parallel.
Tests
npm run pfe-cardlocally; expect build to run in stream and the watch to fire for pfelement, pfe-sass, and pfe-cardReady-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!