Merged
Conversation
kylebuch8
reviewed
Sep 12, 2018
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
I think this looks good but I think we should layout all of the different variations for cta so I can see them side-by-side without having to change the knob each time to see what's different.
What do you think?
Contributor
Author
|
Yeah I was thinking we should have one dynamic and then all variations laid out below. And then maybe a separate story under CTA to show how they react within the context of the various card backgrounds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.