Merged
Conversation
Contributor
Author
|
I'm thinking now that this branch overlaps too much with Krystal's work on the rhelements.github.io docs site. Perhaps the repo should only contain the README (what is RHElements, and quickstart), and then link off to the docs site for all other information. |
Contributor
|
@mwcz I agree. Let's make sure that we get things linked on the official README but I think we'll have to wait for @KrystalMoore16 to be ready. |
Contributor
Author
|
I'll update this PR to include only the README changes, and we can save any contribution guide content for Krystal's site. |
kylebuch8
approved these changes
Oct 3, 2018
Contributor
kylebuch8
left a comment
There was a problem hiding this comment.
Locally Grown Trouble Maker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22
This is not ready to merge yet, just opening it for comments!
I arranged the docs as follows:
The contribution guide is probably what needs the most work. I think this is what it needs in order to be relatively complete:
elements/rhelement/README.mdelements/all/test/)Probably more, that's all I can think of for now. Docs are hard!
@kylebuch8 I know some of the above already exists in rhelements.github.io, but I'm not sure of the best way to dedupe content between this repo and that one.