fix: [pfe-tooltip] forced reflow performance isssues#1702
Merged
heyMP merged 6 commits intoissue-1405-product-trials-epicfrom Jul 14, 2021
Merged
Conversation
github-actions
Bot
added
the
functionality
heyMP
changed the title
|
✔️ Deploy Preview for patternfly-elements ready! 🔨 Explore the source changes: c930845 🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/60e5e36df5ba5f0008a2b9e5 😎 Browse the preview: https://deploy-preview-1702--patternfly-elements.netlify.app |
kylebuch8
reviewed
Jul 8, 2021
Contributor
|
@heyMP Can you update the changelog too? |
kylebuch8
approved these changes
Jul 14, 2021
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Lovely Galactic Transit, Mercury!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a use hovers over a tooltip very quickly and repetitively it was causing warnings for
forced reflow. This is caused when javascript is trying to calculate styles at the same time it's applying them. This would cause sever performance issues.The cause is that we are trying to update the position of the tooltip when the it was about to activate. This would allow the target to potentially move around the screen and the tooltip would always follow it.
Replicate Issue
forced reflowwarning in your consoleTests