Skip to content

fix: IE11 bug for jump links #1727

Merged
castastrophe merged 1 commit intomasterfrom
fix-parseInt-IE-bug
Jul 27, 2021
Merged

fix: IE11 bug for jump links #1727
castastrophe merged 1 commit intomasterfrom
fix-parseInt-IE-bug

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Jul 27, 2021

  • parseInt Number.parseInt doesn't work in IE11, only the globally scoped parseInt does

Browser requirements

Your component should work in all of the following environments:

  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed.
  • Changelog updated (required for fix and feat changes).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@github-actions github-actions Bot added the functionality Functionality, typically pertaining to the JavaScript. label Jul 27, 2021
@castastrophe castastrophe added the ready: code review Ready for code review! label Jul 27, 2021
Copy link
Copy Markdown
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemmy's God Through Metal

@castastrophe castastrophe added priority: medium Severity level: 2 ready to merge and removed ready: code review Ready for code review! labels Jul 27, 2021
@castastrophe castastrophe enabled auto-merge (squash) July 27, 2021 18:47
@castastrophe castastrophe changed the title fix: IE11 bug for jump links fix: IE11 bug for jump links Jul 27, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 27, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 30d0b2f

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/610053d74d3398096a3bdeac

😎 Browse the preview: https://deploy-preview-1727--patternfly-elements.netlify.app

@castastrophe castastrophe merged commit 5f88c39 into master Jul 27, 2021
@castastrophe castastrophe deleted the fix-parseInt-IE-bug branch July 27, 2021 18:58
@castastrophe castastrophe linked an issue Jul 28, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functionality Functionality, typically pertaining to the JavaScript. priority: medium Severity level: 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] pfe-jump-link-nav #IE11

2 participants