Skip to content

Conversation

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 commented Aug 20, 2021

Add page within docs site for typography

Borrowed some of the text from the readme files from pfe-styles and pfe-sass so that there would be evidence of typography styles in the docs.

Preview

Link(s) to demo page(s) where this element can be viewed:

Ready-for-merge Checklist

  • Documentation (README.md, WHY.md, etc.) updated or added.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@starryeyez024 starryeyez024 added the ready: code review Ready for code review! label Aug 20, 2021
@github-actions github-actions bot added docs Documentation updates AT passed Automated testing has passed labels Aug 20, 2021
@github-actions github-actions bot added the demo Updating demo pages label Aug 20, 2021
@netlify
Copy link

netlify bot commented Aug 20, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 1258f34

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/611ffe954d6f9700079eae11

😎 Browse the preview: https://deploy-preview-1753--patternfly-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 20, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 4a2581c

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/6125221e39dab90007cc8673

😎 Browse the preview: https://deploy-preview-1753--patternfly-elements.netlify.app

@starryeyez024 starryeyez024 requested a review from wesruv August 24, 2021 14:43
Copy link
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @starryeyez024!

starryeyez024 and others added 3 commits August 24, 2021 12:44
Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Michael Potter <mgp140@gmail.com>
@starryeyez024
Copy link
Member Author

thank you @heyMP! :D

Copy link
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots Gooder Typography Mate!

@heyMP heyMP enabled auto-merge (squash) August 24, 2021 16:48
@heyMP heyMP merged commit 04ccc7d into master Aug 24, 2021
@heyMP heyMP deleted the docs-typography-overview branch August 24, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates ready: code review Ready for code review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants