Skip to content

Conversation

@heyMP
Copy link
Contributor

@heyMP heyMP commented Sep 28, 2021

Fixes regression in the accent border mixin shared by accordion and jump-links.

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

  • Added px value defaults to @mixin accent-bar() offset. Without them, height and width calc() are invalid CSS.

Testing instructions

  • Accent bar is visible
    1. Go here
    2. Do this

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: efcdb92

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/6153844892fe64000844da7a

😎 Browse the preview: https://deploy-preview-1789--patternfly-elements.netlify.app

@github-actions github-actions bot added the AT passed Automated testing has passed label Sep 28, 2021
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Glutes: Tough Muscles 💪

@kylebuch8 kylebuch8 merged commit eee0712 into master Sep 29, 2021
@kylebuch8 kylebuch8 deleted the issue-1788-jump-links-border-not-working branch September 29, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants