Skip to content

[pfe-accordion]: Updating stylesheets, package.json exports, and gap #2196

Merged
brianferry merged 7 commits intomainfrom
fix/pfe-accordion-sidebar-gap-fix
Oct 21, 2022
Merged

[pfe-accordion]: Updating stylesheets, package.json exports, and gap #2196
brianferry merged 7 commits intomainfrom
fix/pfe-accordion-sidebar-gap-fix

Conversation

@brianferry
Copy link
Copy Markdown
Collaborator

  • Updating the accordion styles to match the format where the variable specific styles go into pfe-accordion.scss instead of BaseAccordion.scss
  • Updating exports for package.json
  • Address sidebar gap when bordered style is used

Related issues

@brianferry brianferry added ready: code review Ready for code review! 1:1 Aligning components with PatternFly v4 labels Oct 21, 2022
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 21, 2022

🦋 Changeset detected

Latest commit: 266bd0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-accordion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the styles An issue or PR pertaining only to CSS/Sass label Oct 21, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2022

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit c8629b8
😎 Deploy Preview https://deploy-preview-2196--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions Bot added the AT passed Automated testing has passed label Oct 21, 2022
Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legos Great To Manipulate

@brianferry brianferry merged commit f53155b into main Oct 21, 2022
@brianferry brianferry deleted the fix/pfe-accordion-sidebar-gap-fix branch October 21, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:1 Aligning components with PatternFly v4 AT passed Automated testing has passed bug fix ready: code review Ready for code review! styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants